add balancerd request limits and set force_conflicts field manager#21
Merged
add balancerd request limits and set force_conflicts field manager#21
Conversation
jubrad
force-pushed
the
add-balancer-resource-reqs
branch
from
c5270d3 to
ba6d3b4
Compare
This was referenced Mar 6, 2025
bobbyiliev
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to be able to set the resource limits on balancerd pods. Balancers don't need much but if we want to support a lot of connections (~5k) we'll need to allow this to be set to a few gigs and a couple cores.
Also updated the field manager to allow force_conflicts. This will be hit if someone manually updates the CRD. In that case I think we want terraform to have priority over manual changes.