fix: Use diffcalc for star rating in /relax top

bathbot/src/active/impls/relax/top.rs

@@ -121,7 +121,8 @@ impl RelaxTopPagination {
             };
 
             let mods = &score.mods;
-            let max_attrs = Context::pp(map).mods(mods.clone()).performance().await;
+            let mut pp_manager = Context::pp(map).mods(mods.clone());
+            let max_attrs = pp_manager.performance().await;
 
             // NOTE: Make generic versions of formatting functions later on
             // this is ugly
@@ -141,7 +142,7 @@ impl RelaxTopPagination {
                 map_id = score.beatmap_id,
                 mods = ModsFormatter::new(mods),
                 pp = PpFormatter::new(score_pp, Some(max_pp)),
-                stars = score.beatmap.star_rating_normal,
+                stars = max_attrs.stars(),
                 acc = round(score.accuracy),
                 score = WithComma::new(score.total_score),
                 combo = ComboFormatter::new(score.combo, Some(max_combo)),
@@ -198,6 +199,4 @@ pub enum RelaxTopOrder {
     Pp,
     #[option(name = "Score", value = "score")]
     Score,
-    #[option(name = "Stars", value = "stars")]
-    Stars,
 }

bathbot/src/commands/osu/relax/top.rs

@@ -119,11 +119,6 @@ pub async fn top(orig: CommandOrigin<'_>, args: RelaxTop<'_>) -> Result<()> {
         RelaxTopOrder::Score => {
             scores.sort_unstable_by(|lhs, rhs| rhs.total_score.cmp(&lhs.total_score))
         }
-        RelaxTopOrder::Stars => scores.sort_unstable_by(|lhs, rhs| {
-            rhs.beatmap
-                .star_rating_normal
-                .total_cmp(&lhs.beatmap.star_rating_normal)
-        }),
     }
 
     let pagination = RelaxTopPagination::builder()