fix: Use diffcalc for star rating in /relax top#1003
Merged
Conversation
MaxOhn
requested changes
Apr 12, 2025
Owner
MaxOhn
left a comment
MaxOhn
left a comment
There was a problem hiding this comment.
Good catch with the sorting issue. I think it's best to remove the sorting option by star rating entirely then unfortunately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We love testing in production :)
Enables use of diffcalc for
/relax topas Relaxation Vault does not return star rating with mods applied. Currently done per-page instead of precalculating for all pages at once as Vault's API isn't paginated and I'm slightly worried about having to calculate a thousand scores on top of having to actually retrieve them in the first placeImportant caveat - this potentially affects sorting by star rating, but I'm not sure how to fix that without allowing the previous issue to persist, as if you calculate only a portion of scores (e.g. 100 at a time), some might slip through anyway