WIP - Equipment/Unit modifiers (salvage quality, partial repair, scenario effect) #6229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft

SJuliez wants to merge 15 commits into MegaMek:master from SJuliez:MUSING-equipment-scenario-effects

Draft

move MekView, separate resources, adaptations for RunMPEquipmentModifier

GitHub Advanced Security / CodeQL succeeded Dec 7, 2024 in 7s

5 new alerts

See annotations below for details.

Code scanning / CodeQL

Chain of 'instanceof' tests Note

This if block performs a chain of 7 type tests - consider alternatives, e.g. polymorphism or the visitor pattern.

Code scanning / CodeQL

Missing Override annotation Note

This method overrides

Modifiable.getModifiers

; it is advisable to add an Override annotation.

Code scanning / CodeQL

Missing Override annotation Note

This method overrides

Modifiable.getModifiers

; it is advisable to add an Override annotation.

Code scanning / CodeQL

Exposing internal representation Note

getDejammableWeapons exposes the internal representation stored in field dejammableWeapons. The value may be modified

after this call to getDejammableWeapons

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable

weapon