Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr#6554 add accurate/stabilized clubs #6555

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DM0000
Copy link
Collaborator

@DM0000 DM0000 commented Feb 15, 2025

fixes #6554

Added modifier checks from weaponAttackAction to clubAttackAction.
Quick copy paste of already implemented checks.

Copy link

codecov bot commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.03%. Comparing base (a9d8f78) to head (6e1d016).
Report is 23 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6555   +/-   ##
=========================================
  Coverage     29.03%   29.03%           
- Complexity    15156    15160    +4     
=========================================
  Files          2836     2836           
  Lines        279292   279295    +3     
  Branches      49237    49233    -4     
=========================================
+ Hits          81098    81101    +3     
  Misses       192821   192821           
  Partials       5373     5373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS
Copy link
Member

Going to approve this, but we should check with CGL if melee weapons can have these quirks. Going to try and get an answer before merge.

@HammerGS HammerGS added the CGL clarification Required This covers any issues that require CGL errata or clarification for us to fix. label Feb 16, 2025
@HammerGS HammerGS marked this pull request as draft February 16, 2025 00:41
@DM0000
Copy link
Collaborator Author

DM0000 commented Feb 16, 2025

Yeah not sure if you can make a club more accurate?(add a scope or grip tape). These are checks to see if a club has the quirk, the adding/removing of quirk not touched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CGL clarification Required This covers any issues that require CGL errata or clarification for us to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accurate Weapon and Stabalized Weapon do not apply correctly to physical weapons like hatchets
2 participants