-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify MHQ Faction and FactionRecord and use yaml faction data files #6735
base: master
Are you sure you want to change the base?
Conversation
Thank you so much for doing this, Juli. As someone who works with factions more than a little, I just wanted to say how appreciated this work is. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6735 +/- ##
==========================================
Coverage 29.33% 29.34%
- Complexity 15600 15631 +31
==========================================
Files 2864 2870 +6
Lines 279533 279745 +212
Branches 49326 49351 +25
==========================================
+ Hits 82004 82080 +76
- Misses 191975 192106 +131
- Partials 5554 5559 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
if (!ratingLevels.isEmpty()) { | ||
pw.println("\t\t<ratingLevels>" + StringEscapeUtils.escapeXml10(String.join(",", ratingLevels)) | ||
+ "</ratingLevels>"); | ||
public void saveIfChanged() throws IOException { |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note
} | ||
// As a temporary measure, the RAT Generator factions are populated from the new unified factions | ||
// list instead of using that directly. | ||
var yamlFactions = Factions2.getInstance(); |
Check warning
Code scanning / CodeQL
Potential input resource leak Warning
return tags; | ||
} | ||
|
||
public List<FactionRecord.DateRange> getYearsActive() { |
Check notice
Code scanning / CodeQL
Exposing internal representation Note
after this call to getYearsActive
getYearsActive exposes the internal representation stored in field yearsActive. The value may be modified
after this call to getYearsActive
Are any of the faction codes in MHQ actually different? Because all of the planetary data depends on these.... |
The faction codes are generally equal aside from some MHQ factions that are missing in the RATs and vice versa and a very small number of, well, data bugs, e.g. we have three versions of the Tamar Pact with different codes. |
Taking a quick glance, the era mods might be an issue. Which mod works with which era? Needs labels. |
Don't suppose you could update the Bandit Caste (BAN code) to include the full range of equipment ratings? While under-equipped - top-rated Bandit Caste is certainly not the same as top-rated Clan forces - there should still be a range of availability from the Society-derived forces fielded by The Jaguar and Tanite/ex-Burrock forces to the dregs that are barely getting by. |
Whoops meant to quote reply and I edited above. If you are editing the factions, we should ensure these are not in use by planetary systems. |
This PR together with MML and MHQ PRs aims to unify the faction data of MHQ and MM on the MM side to make it available everywhere and use individual yaml files instead of a single xml file.
this is unfortunately pretty hefty. Ideally, the whole thing should have no visible effect in MM, MML or MHQ.