Feat/caspar ai #6820
Feat/caspar ai #6820
Conversation
| @@ -33,7 +33,7 @@ private MathUtility() { | |||
| * maximum. Otherwise, this will return the rounded integer between the | |||
| * two points | |||
| */ | |||
| public static int lerp(final int min, final int max, final double f) { | |||
| public static int lerp(int min, int max, double f) { | |||
There was a problem hiding this comment.
final is useless in arguments, so I just removed it.
There was a problem hiding this comment.
It's actually not useless. It prevents the programmer from re-assigning a value to them.
…s cleaner and simpler
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6820 +/- ##
============================================
+ Coverage 30.06% 30.08% +0.01%
- Complexity 15597 15633 +36
============================================
Files 2872 2877 +5
Lines 282720 282836 +116
Branches 49259 49258 -1
============================================
+ Hits 85002 85084 +82
- Misses 192154 192187 +33
- Partials 5564 5565 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…time, need to change it so it just fails if value is higher than a certain percent
| @@ -33,7 +33,7 @@ private MathUtility() { | |||
| * maximum. Otherwise, this will return the rounded integer between the | |||
| * two points | |||
| */ | |||
| public static int lerp(final int min, final int max, final double f) { | |||
| public static int lerp(int min, int max, double f) { | |||
There was a problem hiding this comment.
It's actually not useless. It prevents the programmer from re-assigning a value to them.
megamek/unittests/megamek/ai/neuralnetwork/NeuralNetworkTest.java
Outdated
Show resolved
Hide resolved
It depends... Ideally I want to create at least 5 AI models (Beginer, easy, normal, hard, hardcore), and maybe two or three "flavors" for each of those too would be interesting (if viable). I may try to make them read directly from zip files, or at least tar all the model files into one thing instead? Need to check Tensorflow's API. But the models sohuld not change alot once done, unless someone is doing anything with them, like adding new stuff or tuning, in any way, its usually just a file replace. |
|
Alright. The speed of change was my concern as the way Git handles binary is it just re-adds the entire file. Not changing often, not really an issue. |
…data for testing, I want it all to be self contained
Scoppio
added
the
For New Dev Cycle
There was a problem hiding this comment.
Copilot reviewed 25 out of 29 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- megamek/build.gradle: Language not supported
- megamek/data/ai/brains/default/fingerprint.pb: Language not supported
- megamek/data/ai/brains/default/keras_metadata.pb: Language not supported
- megamek/data/ai/brains/default/min_max_feature_normalization.csv: Language not supported
Comments suppressed due to low confidence (1)
megamek/src/megamek/ai/neuralnetwork/Brain.java:128
- [nitpick] The error message for a failed prediction is unclear and may be confusing. Consider revising the message to something more informative like 'Prediction failed due to an unexpected error' for improved clarity.
logger.error("Prediction failed, there is no recourse from this", e);
| * @return The value clamped | ||
| */ | ||
| public static float clamp01(float value) { | ||
| return clamp(value, 0f, 1f); |
There was a problem hiding this comment.
The clamp01 methods are calling a clamp method with float/double arguments, but the existing clamp method appears to operate on long values. Consider adding overloads of clamp for float and double types or casting the arguments appropriately to ensure type consistency.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Adds basic stuff needed for Caspar, and updates the games action log.