Feat/caspar ai #6820

Scoppio · 2025-04-03T04:08:04Z

Adds basic stuff needed for Caspar, and updates the games action log.

…ow lib

Scoppio · 2025-04-03T04:09:28Z

megamek/src/megamek/codeUtilities/MathUtility.java

@@ -33,7 +33,7 @@ private MathUtility() {
     *         maximum. Otherwise, this will return the rounded integer between the
     *         two points
     */
-    public static int lerp(final int min, final int max, final double f) {
+    public static int lerp(int min, int max, double f) {


final is useless in arguments, so I just removed it.

It's actually not useless. It prevents the programmer from re-assigning a value to them.

…s cleaner and simpler

codecov · 2025-04-03T04:15:38Z

Codecov Report

Attention: Patch coverage is 56.20915% with 67 lines in your changes missing coverage. Please review.

Project coverage is 30.24%. Comparing base (d056ccd) to head (5b009af).
Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
megamek/src/megamek/common/CubeCoords.java	5.00%	38 Missing ⚠️
megamek/src/megamek/ai/neuralnetwork/Brain.java	83.67%	7 Missing and 1 partial ⚠️
...amek/client/bot/caspar/MovementClassification.java	60.00%	5 Missing and 1 partial ⚠️
.../neuralnetwork/FeatureNormalizationParameters.java	83.33%	3 Missing and 1 partial ⚠️
...megamek/client/bot/caspar/ClassificationScore.java	69.23%	4 Missing ⚠️
...egamek/client/bot/princess/SwarmCenterManager.java	0.00%	3 Missing ⚠️
.../src/megamek/client/bot/princess/SwarmContext.java	0.00%	3 Missing ⚠️
megamek/src/megamek/codeUtilities/MathUtility.java	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             master    #6820    +/-   ##
==========================================
  Coverage     30.24%   30.24%            
- Complexity    15811    15831    +20     
==========================================
  Files          2885     2890     +5     
  Lines        283286   283427   +141     
  Branches      49335    49345    +10     
==========================================
+ Hits          85667    85720    +53     
- Misses       192013   192105    +92     
+ Partials       5606     5602     -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

megamek/src/megamek/client/bot/caspar/ClassificationScore.java

…time, need to change it so it just fails if value is higher than a certain percent

rjhancock

How often will the binary files change?

Other than a few comments and a few classes could use (not required) some top level JavaDocs, it looks good for the initial PR.

rjhancock · 2025-04-03T04:52:28Z

megamek/src/megamek/codeUtilities/MathUtility.java

@@ -33,7 +33,7 @@ private MathUtility() {
     *         maximum. Otherwise, this will return the rounded integer between the
     *         two points
     */
-    public static int lerp(final int min, final int max, final double f) {
+    public static int lerp(int min, int max, double f) {


It's actually not useless. It prevents the programmer from re-assigning a value to them.

megamek/src/megamek/codeUtilities/MathUtility.java

megamek/unittests/megamek/ai/neuralnetwork/NeuralNetworkTest.java

Scoppio · 2025-04-03T23:08:09Z

How often will the binary files change?

Other than a few comments and a few classes could use (not required) some top level JavaDocs, it looks good for the initial PR.

It depends... Ideally I want to create at least 5 AI models (Beginer, easy, normal, hard, hardcore), and maybe two or three "flavors" for each of those too would be interesting (if viable).

I may try to make them read directly from zip files, or at least tar all the model files into one thing instead? Need to check Tensorflow's API. But the models sohuld not change alot once done, unless someone is doing anything with them, like adding new stuff or tuning, in any way, its usually just a file replace.

rjhancock · 2025-04-03T23:35:25Z

Alright. The speed of change was my concern as the way Git handles binary is it just re-adds the entire file. Not changing often, not really an issue.

megamek/unittests/megamek/ai/neuralnetwork/BrainTest.java

…data for testing, I want it all to be self contained

… file

megamek/unittests/megamek/ai/neuralnetwork/BrainTest.java

Copilot

Copilot reviewed 25 out of 29 changed files in this pull request and generated 1 comment.

Files not reviewed (4)

megamek/build.gradle: Language not supported
megamek/data/ai/brains/default/fingerprint.pb: Language not supported
megamek/data/ai/brains/default/keras_metadata.pb: Language not supported
megamek/data/ai/brains/default/min_max_feature_normalization.csv: Language not supported

Comments suppressed due to low confidence (1)

megamek/src/megamek/ai/neuralnetwork/Brain.java:128

[nitpick] The error message for a failed prediction is unclear and may be confusing. Consider revising the message to something more informative like 'Prediction failed due to an unexpected error' for improved clarity.

logger.error("Prediction failed, there is no recourse from this", e);

Copilot · 2025-04-06T22:25:28Z

megamek/src/megamek/codeUtilities/MathUtility.java

+     * @return The value clamped
+     */
+    public static float clamp01(float value) {
+        return clamp(value, 0f, 1f);


The clamp01 methods are calling a clamp method with float/double arguments, but the existing clamp method appears to operate on long values. Consider adding overloads of clamp for float and double types or casting the arguments appropriately to ensure type consistency.

HammerGS · 2025-04-26T20:35:10Z

@Scoppio Failing checks

The job fails due to multiple compilation errors in /src/megamek/ai/dataset/UnitPath.java. The issue is that the UnitAction class is missing the methods being called, such as currentCubePosition(), finalCubePosition(), currentPosition(), finalPosition() and others.

Copilot

Pull Request Overview

This pull request introduces foundational changes for the Caspar AI feature while updating multiple related components including unit tests for the neural network, interface definitions for movement pathing, and TensorFlow model integration. Key updates include:

Adding a new set of unit tests for the neural network under the AI module.
Defining and implementing the Pathing interface in MovePath and updating CubeCoords to use record syntax.
Extending Configuration and MathUtility with AI‐related methods and integrating TensorFlow model loading in the Brain class.

Reviewed Changes

Copilot reviewed 20 out of 24 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
megamek/unittests/megamek/ai/neuralnetwork/BrainTest.java	Introduces tests for brain loading and neural network predictions.
megamek/src/megamek/common/Pathing.java	Defines the new Pathing interface for movement-related operations.
megamek/src/megamek/common/MovePath.java	Implements the Pathing interface and adds necessary method overrides.
megamek/src/megamek/common/CubeCoords.java	Refactors CubeCoords as a record with additional helper methods.
megamek/src/megamek/common/Configuration.java	Adds methods for retrieving AI brain directories and normalization files.
megamek/src/megamek/codeUtilities/MathUtility.java	Introduces clamp01 methods for clamping float/double values.
megamek/src/megamek/client/bot/princess/SwarmContext.java megamek/src/megamek/client/bot/princess/SwarmCenterManager.java	Updates usage of CubeCoords record accessors.
megamek/src/megamek/client/bot/caspar/MovementClassification.java ClassificationScore.java	Adds new AI-related movement classification support.
megamek/src/megamek/ai/neuralnetwork/**	Adds FeatureNormalizationParameters, BrainRegistry, and Brain classes to support TensorFlow integration for AI.
megamek/src/megamek/ai/dataset/**	Minor updates to serializer and dataset handling classes.

Files not reviewed (4)

megamek/build.gradle: Language not supported
megamek/data/ai/brains/default/fingerprint.pb: Language not supported
megamek/data/ai/brains/default/keras_metadata.pb: Language not supported
megamek/data/ai/brains/default/min_max_feature_normalization.csv: Language not supported

Comments suppressed due to low confidence (1)

megamek/unittests/megamek/ai/neuralnetwork/BrainTest.java:56

[nitpick] Consider renaming 'BRAIN' to follow standard naming conventions (e.g., using camelCase such as 'brain') since it is not a constant.

private static Brain BRAIN;

megamek/src/megamek/ai/neuralnetwork/FeatureNormalizationParameters.java

megamek/src/megamek/ai/neuralnetwork/Brain.java

+        try {
+            return SavedModelBundle.load(Configuration.aiBrainFolderPath(brainRegistry.name()).toString());
+        } catch (TensorFlowException e) {
+            logger.error(e, "Failed to load TensorFlow model: {}", e.getMessage());


Scoppio added 6 commits April 2, 2025 21:43

feat: added the default FFNN model trained for tests and the tensorfl…

446e83e

…ow lib

feat: added clamp01 to mathutility

2b181ef

feat: cube coords expanded, added pathing interface and unit path

1717dec

feat: updated serde for game action data

8ff7743

feat: functional model testing and FFNN loading up correctly

4d1c6eb

feat: improvements in the ergonomics of the NN class

6b1b2e2

Scoppio self-assigned this Apr 3, 2025

Scoppio commented Apr 3, 2025

View reviewed changes

Scoppio force-pushed the feat/caspar-ai branch from 23314e8 to e0ea1cd Compare April 3, 2025 04:10

chore: input normalization now load itself, making the NN load proces…

6e29575

…s cleaner and simpler

Scoppio force-pushed the feat/caspar-ai branch from e0ea1cd to 6e29575 Compare April 3, 2025 04:11

github-advanced-security bot found potential problems Apr 3, 2025

View reviewed changes

megamek/src/megamek/client/bot/caspar/ClassificationScore.java Fixed Show fixed Hide fixed

feat: adding test-eval cases, but they are failing 39 percent of the …

0f64812

…time, need to change it so it just fails if value is higher than a certain percent

rjhancock reviewed Apr 3, 2025

View reviewed changes

megamek/unittests/megamek/ai/neuralnetwork/NeuralNetworkTest.java Outdated Show resolved Hide resolved

Merge branch 'master' into feat/caspar-ai

512b9db

Scoppio added 2 commits April 5, 2025 15:08

feat: added tests for evaluating if the model is working, loading, etc.

4cf8825

Merge branch 'master' into feat/caspar-ai

a6468a1

github-advanced-security bot found potential problems Apr 5, 2025

View reviewed changes

megamek/unittests/megamek/ai/neuralnetwork/BrainTest.java Fixed Show fixed Hide fixed

megamek/unittests/megamek/ai/neuralnetwork/BrainTest.java Fixed Show fixed Hide fixed

Scoppio added 2 commits April 5, 2025 17:13

chore: refactor the test setup, moving inside the Brain all the load …

9db1413

…data for testing, I want it all to be self contained

chore: removed testNN and moved the brain test setup back to the test…

fab4781

… file

github-advanced-security bot found potential problems Apr 5, 2025

View reviewed changes

megamek/unittests/megamek/ai/neuralnetwork/BrainTest.java Fixed Show fixed Hide fixed

megamek/unittests/megamek/ai/neuralnetwork/BrainTest.java Fixed Show resolved Hide resolved

github-advanced-security bot found potential problems Apr 5, 2025

View reviewed changes

megamek/unittests/megamek/ai/neuralnetwork/BrainTest.java Fixed Show resolved Hide resolved

Scoppio added the For New Dev Cycle This PR should be merged at the beginning of a dev cycle label Apr 5, 2025

feat: put Pathing as interface to MovePath

3898ac6

Scoppio force-pushed the feat/caspar-ai branch from 822c6be to 3898ac6 Compare April 5, 2025 20:54

rjhancock approved these changes Apr 6, 2025

View reviewed changes

megamek/unittests/megamek/ai/neuralnetwork/BrainTest.java Fixed Show resolved Hide resolved

megamek/unittests/megamek/ai/neuralnetwork/BrainTest.java Fixed Show resolved Hide resolved

Merge branch 'MegaMek:master' into feat/caspar-ai

1d55840

Scoppio force-pushed the feat/caspar-ai branch from 27e9110 to dd1f498 Compare April 6, 2025 21:08

Scoppio requested a review from Copilot April 6, 2025 22:24

Copilot AI reviewed Apr 6, 2025

View reviewed changes

fix: update float and int for test data

d7f4627

Scoppio force-pushed the feat/caspar-ai branch from dd1f498 to d7f4627 Compare April 6, 2025 22:52

fix: fixed merge conflicts

971ca3b

Scoppio force-pushed the feat/caspar-ai branch from 9f3cc14 to 971ca3b Compare April 25, 2025 22:44

rjhancock previously approved these changes Apr 25, 2025

View reviewed changes

HammerGS removed the For New Dev Cycle This PR should be merged at the beginning of a dev cycle label Apr 26, 2025

Scoppio added 3 commits April 26, 2025 20:37

Merge branch 'master' into feat/caspar-ai

8020041

fix: removed UnitPath

0fd5582

Merge branch 'master' into feat/caspar-ai

5b009af

Scoppio requested a review from Copilot April 27, 2025 14:22

Copilot AI reviewed Apr 27, 2025

View reviewed changes

megamek/src/megamek/ai/neuralnetwork/FeatureNormalizationParameters.java Outdated Show resolved Hide resolved

Merge branch 'master' into feat/caspar-ai

ac8b0fc

Scoppio marked this pull request as draft April 27, 2025 21:10

feat: small improvements

31158e5

github-advanced-security bot found potential problems Apr 27, 2025

View reviewed changes

Scoppio dismissed rjhancock’s stale review via 31158e5 April 28, 2025 03:28

Scoppio marked this pull request as ready for review April 28, 2025 03:29

Scoppio requested a review from a team as a code owner April 28, 2025 03:29

Merge branch 'master' into feat/caspar-ai

692aebb

Scoppio added For New Dev Cycle This PR should be merged at the beginning of a dev cycle Princess/AI Issues or PR that relate to the current Bot AI PACAR Any Issues related to the PACAR (Princess Abstract Combat Auto Resolve) System labels Apr 28, 2025

Merge branch 'master' into feat/caspar-ai

3f00f6f

Scoppio requested a review from a team as a code owner May 10, 2025 03:40

Feat/caspar ai #6820

Are you sure you want to change the base?

Feat/caspar ai #6820

Uh oh!

Conversation

Scoppio commented Apr 3, 2025

Uh oh!

Scoppio Apr 3, 2025

Choose a reason for hiding this comment

Uh oh!

rjhancock Apr 3, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

rjhancock left a comment

Choose a reason for hiding this comment

Uh oh!

rjhancock Apr 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Scoppio commented Apr 3, 2025

Uh oh!

rjhancock commented Apr 3, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2025

Choose a reason for hiding this comment

Uh oh!

HammerGS commented Apr 26, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Check warning

Uh oh!

codecov bot commented Apr 3, 2025 •

edited

Loading