feat: slightly better serializer for unit actions and state, added attack action too

[Scoppio]

What it does?

Improves the current TSV Serializer and the actions for the game dataset logger.

• Adds more fields too for UnitAction and UnitState
• Adds AttackUnitAction
• and a few new function for EntityFeatureUtils that can gets the percent of armor on each "side" of a unit. Mostly used exclusively for Dataset logger right now, but will be used for other things on the feature extractor/axis calculator for caspar at a later date.
• Cover all data that was missing for custom units, and the info that was missing and I had to extract directly from MegaMek to run my model trainer.

[codecov]

Codecov Report

Attention: Patch coverage is 41.47399% with 405 lines in your changes missing coverage. Please review.

Project coverage is 30.12%. Comparing base (95a1af5) to head (116302e).
Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
megamek/src/megamek/ai/dataset/UnitAttack.java	25.71%	78 Missing ⚠️
megamek/src/megamek/ai/dataset/UnitAction.java	35.92%	66 Missing ⚠️
megamek/src/megamek/ai/dataset/UnitState.java	38.46%	56 Missing ⚠️
megamek/src/megamek/ai/dataset/GameData.java	15.90%	37 Missing ⚠️
...k/src/megamek/ai/dataset/EntityDataSerializer.java	28.57%	35 Missing ⚠️
megamek/src/megamek/common/GameDatasetLogger.java	19.35%	25 Missing ⚠️
...ek/src/megamek/ai/dataset/BoardDataSerializer.java	8.00%	23 Missing ⚠️
megamek/src/megamek/ai/dataset/BoardData.java	19.23%	21 Missing ⚠️
...mek/src/megamek/ai/dataset/GameDataSerializer.java	12.50%	21 Missing ⚠️
megamek/src/megamek/ai/dataset/EntityDataMap.java	0.00%	17 Missing ⚠️
... and 4 more

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #6834      +/-   ##
============================================
+ Coverage     30.05%   30.12%   +0.07%     
- Complexity    15587    15621      +34     
============================================
  Files          2875     2884       +9     
  Lines        282748   283107     +359     
  Branches      49302    49296       -6     
============================================
+ Hits          84988    85299     +311     
- Misses       192210   192246      +36     
- Partials       5550     5562      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

[Copilot]

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

[Copilot]

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

megamek/src/megamek/common/Compute.java:474

• Verify the removal of the 'false' parameter from the climb method call to ensure that the change in behavior is intentional.

game.getBoard().getHex(coords), elevation, climbMode);

megamek/src/megamek/ai/dataset/UnitAction.java:62

• The update of the initial value in the reduce operation from 0.0 to 1.0 is crucial for correctly computing the chanceOfFailure; please document or verify that multiplying the PSR values was the intended fix.

double chanceOfFailure = SharedUtility.getPSRList(movePath).stream()
                                       .map(psr -> psr.getValue() / 36d)
                                       .reduce(1.0, (a, b) -> a * b);

megamek/src/megamek/ai/dataset/UnitStateSerializer.java:70

• Ensure that additional fields (like HAS_ECM and armor side percentages) introduced in the UnitState record are adequately tested in the serializer tests.

row[UnitStateField.HAS_ECM.ordinal()] = obj.hasEcm() ? "1" : "0";

[Sleet01]

After some discussion on Discord I have changed my mind on the records approach.
Everything looks good, excited to see the next steps!

[Scoppio]

After some discussion on Discord I have changed my mind on the records approach. Everything looks good, excited to see the next steps!

And I changed my mind... this is really annoying to improve upon, so I am throwing the towel and going for the thing I didnt wanted to do before but is possibly the correct solution, using an EnumHashMap to hold the values and use reflection to serialize the object.

[Sleet01]

Looks good! Nice job compacting some of that code down.

[Copilot]

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

megamek/src/megamek/common/Compute.java:474

• The removal of the false boolean argument in the climb method call appears intentional. Please verify that the change aligns with the updated method signature and intended behavior.

elevation, climbMode);

[Copilot]

The logger.error call here reverses the parameter order compared to other error logs. For consistency and clarity, update it to logger.error("Error logging Attack unit action", ex).

Suggested change

	logger.error(ex, "Error logging Attack unit action");
	}
	logger.error("Error logging Attack unit action", ex);

[Scoppio]

The original code is correct

already fixed