-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tip of the day #6841
base: master
Are you sure you want to change the base?
tip of the day #6841
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6841 +/- ##
============================================
- Coverage 30.05% 30.04% -0.02%
+ Complexity 15587 15579 -8
============================================
Files 2875 2876 +1
Lines 282748 282872 +124
Branches 49302 49316 +14
============================================
- Hits 84988 84981 -7
- Misses 192210 192336 +126
- Partials 5550 5555 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On lower-resolution screens the tip is too large relative to the splash.
That would be due to the hints. What they do internally is essentially double the size of the render and scale it down. On HiDPI/Retina screens they show correctly. On "normal" screens they are twice the size. Or that is my theory on it anyways. |
Instead of rending to a Graphics context, why not render to a Swing object that can be inserted somewhere on the screen? |
Originally I did that with a layeredpane but I was getting very bad aliasing and ugly stroke. This was the most visually pleasing approach. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The license header needs to be updated to the correct version and you'll need to update latest master into this and fix the calls to the Internationalization class to I18N.
Almost there.
add common Tip Of The Day implementation with i18n support.