Skip to content

board editor - trace overlay #6935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

kuronekochomusuke
Copy link
Collaborator

@kuronekochomusuke kuronekochomusuke commented Apr 26, 2025

  • add a trace overlay to the board editor

image
image
image
image
image

@kuronekochomusuke kuronekochomusuke added the Map Editor Issues related to the Map Editor, includes Bugs and RFE's. Does NOT include Tileset issues label Apr 26, 2025
@kuronekochomusuke kuronekochomusuke marked this pull request as draft April 26, 2025 21:06
Copy link

codecov bot commented Apr 26, 2025

Codecov Report

Attention: Patch coverage is 3.29670% with 176 lines in your changes missing coverage. Please review.

Project coverage is 30.21%. Comparing base (e1ec50f) to head (75c3d40).
Report is 102 commits behind head on master.

Files with missing lines Patch % Lines
.../megamek/client/ui/swing/CommonSettingsDialog.java 0.00% 118 Missing ⚠️
...lient/ui/swing/boardview/overlay/TraceOverlay.java 0.00% 34 Missing ⚠️
...ek/src/megamek/client/ui/swing/GUIPreferences.java 25.00% 18 Missing ⚠️
...mek/src/megamek/client/ui/swing/CommonMenuBar.java 0.00% 5 Missing ⚠️
...gamek/src/megamek/client/ui/swing/BoardEditor.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6935      +/-   ##
============================================
- Coverage     30.23%   30.21%   -0.03%     
- Complexity    15786    15793       +7     
============================================
  Files          2885     2886       +1     
  Lines        283167   283466     +299     
  Branches      49303    49345      +42     
============================================
+ Hits          85622    85637      +15     
- Misses       191947   192232     +285     
+ Partials       5598     5597       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HammerGS
Copy link
Member

Would this allow you to upload an image say of an existing map and then be able to trace over it?

@kuronekochomusuke
Copy link
Collaborator Author

any image, it just displays it. you still have to build the map as usual, can just be guided by the image.

@HammerGS
Copy link
Member

Thats amazing, so you could screen a new map and start to fill it out.

@kuronekochomusuke kuronekochomusuke changed the title Trace overlay board editory - trace overlay Apr 27, 2025
@kuronekochomusuke kuronekochomusuke changed the title board editory - trace overlay board editor - trace overlay Apr 27, 2025
@kuronekochomusuke kuronekochomusuke marked this pull request as ready for review April 28, 2025 23:28
@kuronekochomusuke kuronekochomusuke requested a review from a team as a code owner April 28, 2025 23:28
Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rjhancock rjhancock added the For New Dev Cycle This PR should be merged at the beginning of a dev cycle label Apr 29, 2025
@rjhancock
Copy link
Collaborator

Not a bug fix. Next cycle. :) But this will be a great addition.

@BLR-IIC
Copy link
Contributor

BLR-IIC commented May 2, 2025

This is awesome! It'll be easier for me to use Google Maps to recreate my neighborhood as a battlefield XD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For New Dev Cycle This PR should be merged at the beginning of a dev cycle Map Editor Issues related to the Map Editor, includes Bugs and RFE's. Does NOT include Tileset issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants