feat: adds CONVOY behavior setting preset and flag to ignore damage output on pathing #6944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…king, also adds special case where unit will face destination
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new CONVOY behavior preset along with a flag to ignore damage output, affecting both path ranking and behavior settings. Key changes include:
- Introduction of new clamp methods (clamp01 and clampUlp1) in MathUtility.
- Updates to BotConfigDialog and various bot components (UtilityPathRanker, BasicPathRanker, BehaviorSettings, etc.) to incorporate the ignoreDamageOutput flag.
- Enhanced Javadoc documentation and minor logging improvements.
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| megamek/src/megamek/codeUtilities/MathUtility.java | Added helper clamp methods with accompanying Javadoc |
| megamek/src/megamek/client/ui/dialogs/BotConfigDialog.java | Added UI component and action handling for ignoreDamageOutput flag |
| megamek/src/megamek/client/bot/princess/UtilityPathRanker.java | Updated path ranking logic to account for ignoreDamageOutput flag |
| megamek/src/megamek/client/bot/princess/Princess.java | Logging improvements with parameterized messages |
| megamek/src/megamek/client/bot/princess/PathRanker.java | Expanded Javadoc and minor logic updates for path ranking |
| megamek/src/megamek/client/bot/princess/BehaviorSettingsFactory.java | Added new CONVOY preset and null-checks for behavior presets |
| megamek/src/megamek/client/bot/princess/BehaviorSettings.java | Added new field and XML serialization for ignoreDamageOutput flag |
| megamek/src/megamek/client/bot/princess/BasicPathRanker.java | Enhanced documentation and integrated ignoreDamageOutput flag in scoring |
Files not reviewed (1)
- megamek/i18n/megamek/client/messages.properties: Language not supported
Comments suppressed due to low confidence (1)
megamek/src/megamek/client/bot/princess/UtilityPathRanker.java:150
- [nitpick] When the ignoreDamageOutput flag is enabled, both physicalDamage and firingDamage are set to 0. Please confirm that disabling both damage types is the intended behavior in all scenarios.
if (getOwner().getBehaviorSettings().isIgnoreDamageOutput()) {
Scoppio
added
Princess/AI
PACAR
Scoppio
added
the
For New Dev Cycle
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6944 +/- ##
=========================================
Coverage 30.22% 30.23%
- Complexity 15789 15797 +8
=========================================
Files 2885 2885
Lines 283286 283333 +47
Branches 49335 49342 +7
=========================================
+ Hits 85633 85661 +28
- Misses 192052 192056 +4
- Partials 5601 5616 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The clamp01() method indicates "The value if it is inside the range given by the limits (inclusive)", but it only has one input - the value to be clamped. It should include either values to clamp between as arguments, or the JavaDoc updated to show that it is clamping between 0.0 and 1.0 (or whatever values are hard coded). |
rjhancock
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it about?
Adds CONVOY behavior setting preset, a behavior controlling flag to ignore damage output (damage that would be caused by this unit onto enemies) when calculating pathing utility score was added, also adds special case where unit will give priority to face towards its destination when fleeing but only if it has the flag
ignore damage outputenabled.What it does?
This small feature adds a simple behavior control toggle
Anything else?
Alot of Javadoc was added on BasicPathRanker to better explain what is happening.
Issues:
This PR potentially resolves the following RFE's