added dispose() on some dialogs (fix memory leaks) #6959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds dispose() calls via overriding cancelAction() in both dialog classes to ensure proper resource cleanup when a cancel action is triggered.
- Overrides cancelAction() in WeightDisplayDialog to call dispose().
- Overrides cancelAction() in CostDisplayDialog to call dispose().
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| megamek/src/megamek/client/ui/dialogs/WeightDisplayDialog.java | Added cancelAction() override that calls dispose() for proper resource cleanup. |
| megamek/src/megamek/client/ui/dialogs/CostDisplayDialog.java | Added cancelAction() override that calls dispose() for proper resource cleanup. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6959 +/- ##
=========================================
Coverage 30.31% 30.31%
- Complexity 15807 15810 +3
=========================================
Files 2886 2886
Lines 283126 283140 +14
Branches 49326 49326
=========================================
+ Hits 85833 85844 +11
+ Misses 191694 191691 -3
- Partials 5599 5605 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
exeea
changed the title
rjhancock
added
the
For New Dev Cycle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes few memory leaks.
Added dispose() calls to:
those are dialogs that are spawned every time, never reused.