PR: Refactored power generators to use new PowerGeneratorType instead of MiscType#7762
Merged
psikomonkie merged 2 commits intoMegaMek:mainfrom Dec 13, 2025
Merged
Conversation
…cType` instead of a `MiscType`. Instead of using subflags to mark what kind of `StructureEngine` a `PowerGeneratorType` has, we just keep the `StructureEngine` enum.
psikomonkie
changed the title
PowerGeneratorType instead of MiscTypePowerGeneratorType instead of MiscType
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7762 +/- ##
============================================
- Coverage 29.23% 29.19% -0.05%
+ Complexity 15281 15243 -38
============================================
Files 3120 3121 +1
Lines 298182 298184 +2
Branches 51947 51946 -1
============================================
- Hits 87180 87047 -133
- Misses 202438 202625 +187
+ Partials 8564 8512 -52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Refactored power generators to be
PowerGeneratorType extends MiscTypeinstead of aMiscType. Instead of using subflags to mark what kind ofStructureEngineaPowerGeneratorTypehas, we just keep theStructureEngineenum.This is to support #7758 which is removing subflags.
There should be no gameplay impact from this - there are no units that use power generators.