Converted Honor Rating into an Enum#5962
Merged
HammerGS merged 2 commits intoMegaMek:masterfrom Feb 6, 2025
IllianiBird:honorRatingEnum
Merged
Converted Honor Rating into an Enum#5962HammerGS merged 2 commits intoMegaMek:masterfrom IllianiBird:honorRatingEnum
HammerGS merged 2 commits intoMegaMek:masterfrom
IllianiBird:honorRatingEnum
Conversation
- Replaced hardcoded honor rating logic with an `HonorRating` enum for better readability and maintainability. - Moved honor rating computation to the `Faction` class, simplifying related code in `AtBDynamicScenarioFactory`.
Updated copyright headers in HonorRating.java and Faction.java to reflect the current years of 2025. Ensured consistency with licensing and copyright information across the files.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5962 +/- ##
============================================
- Coverage 10.35% 10.33% -0.03%
+ Complexity 6171 6153 -18
============================================
Files 1039 1040 +1
Lines 139359 139364 +5
Branches 20639 20637 -2
============================================
- Hits 14437 14407 -30
- Misses 123493 123521 +28
- Partials 1429 1436 +7 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HonorRatingenum for better readability and maintainability.Factionclass, simplifying related code inAtBDynamicScenarioFactory.