Refactored PrisonerStatus Enum and Reorganized Related Code#5963
Merged
HammerGS merged 4 commits intoMegaMek:masterfrom Feb 6, 2025
IllianiBird:prisonerStatusEnum
Merged
Refactored PrisonerStatus Enum and Reorganized Related Code#5963HammerGS merged 4 commits intoMegaMek:masterfrom IllianiBird:prisonerStatusEnum
PrisonerStatus Enum and Reorganized Related Code#5963HammerGS merged 4 commits intoMegaMek:masterfrom
IllianiBird:prisonerStatusEnum
Conversation
- Moved `PrisonerStatus` enum to a new package for `randomEvents` as this is where the prisoner code will be living once the upcoming prisoner rework is merged. - Adjusted all references accordingly - Added new test cases and updating resource bundles.
Updated all relevant files to extend copyright years to 2025 for the MegaMek Team. This ensures compliance with the project's legal and licensing requirements.
IllianiBird
added
Tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5963 +/- ##
=========================================
Coverage 10.29% 10.29%
- Complexity 6106 6108 +2
=========================================
Files 1038 1038
Lines 139308 139302 -6
Branches 20665 20664 -1
=========================================
Hits 14337 14337
+ Misses 123543 123533 -10
- Partials 1428 1432 +4 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Feb 6, 2025
Member
|
@IllianiCBT Conflicts |
# Conflicts: # MekHQ/unittests/mekhq/campaign/personnel/death/AbstractDeathTest.java
# Conflicts: # MekHQ/src/mekhq/campaign/Campaign.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PrisonerStatusenum to a new package forrandomEventsas this is where the prisoner code will be living once the upcoming prisoner rework is merged.