Use ModifiedConstantSkillGenerator for Skill Generation#5964
Merged
HammerGS merged 1 commit intoMegaMek:masterfrom Feb 6, 2025
IllianiBird:modifiedConstantSkillGenerator_switch
Merged
Use ModifiedConstantSkillGenerator for Skill Generation#5964HammerGS merged 1 commit intoMegaMek:masterfrom IllianiBird:modifiedConstantSkillGenerator_switch
ModifiedConstantSkillGenerator for Skill Generation#5964HammerGS merged 1 commit intoMegaMek:masterfrom
IllianiBird:modifiedConstantSkillGenerator_switch
Conversation
Replaced `TaharqaSkillGenerator` with `ModifiedConstantSkillGenerator` in `AtBScenarioModifierApplicator` and `BotForceRandomizer`. This ensures consistency with updated skill generation logic used elsewhere in MekHQ. I updated our generation methods back in 2024, but apparently missed these two instances.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5964 +/- ##
============================================
- Coverage 10.35% 10.34% -0.02%
+ Complexity 6171 6159 -12
============================================
Files 1039 1039
Lines 139359 139359
Branches 20639 20639
============================================
- Hits 14437 14422 -15
- Misses 123493 123504 +11
- Partials 1429 1433 +4 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TaharqaSkillGeneratorwithModifiedConstantSkillGeneratorinAtBScenarioModifierApplicatorandBotForceRandomizer.This ensures consistency with updated skill generation logic used elsewhere in MekHQ. I updated our generation methods back in 2024, but apparently missed these two instances.