Added 'None' Generation Method to ScenarioForceTemplate#5966
Merged
HammerGS merged 1 commit intoMegaMek:masterfrom Feb 6, 2025
IllianiBird:emptyBotForceGeneration
Merged
Added 'None' Generation Method to ScenarioForceTemplate#5966HammerGS merged 1 commit intoMegaMek:masterfrom IllianiBird:emptyBotForceGeneration
ScenarioForceTemplate#5966HammerGS merged 1 commit intoMegaMek:masterfrom
IllianiBird:emptyBotForceGeneration
Conversation
- Implemented a 'None' option in `ForceGenerationMethod` to allow bot forces where no units are generated, enabling more flexible scenario templates. - Adjusted `AtBDynamicScenarioFactory` to account for this method in force generation logic. This resolves a situation where we need to have all objective-significant Bot Forces generated when the scenario is created. However, if we want the Bot Force to have specific units and not random ones, we then need to remove the already generated ones. By using this method, we're able to generate an empty force during scenario creation which can then be populated later. This will be used by the upcoming prisoner rework.
IllianiBird
added
the
Improvement to Existing Feature
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5966 +/- ##
============================================
- Coverage 10.35% 10.35% -0.01%
+ Complexity 6171 6167 -4
============================================
Files 1039 1039
Lines 139359 139363 +4
Branches 20639 20641 +2
============================================
- Hits 14437 14430 -7
- Misses 123493 123501 +8
- Partials 1429 1432 +3 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ForceGenerationMethodto allow bot forces where no units are generated, enabling more flexible scenario templates.AtBDynamicScenarioFactoryto account for this method in force generation logic.This resolves a situation where we need to have all objective-significant Bot Forces generated when the scenario is created. However, if we want the Bot Force to have specific units and not random ones, we then need to remove the already generated ones. By using this method, we're able to generate an empty force during scenario creation which can then be populated later.
This will be used by the upcoming prisoner rework.