Updated Admin Strain Nag to Use Immersive Dialog#6376
Merged
IllianiBird merged 2 commits intoMegaMek:masterfrom Mar 24, 2025
IllianiBird:AdminStrainNagNew
Merged
Updated Admin Strain Nag to Use Immersive Dialog#6376IllianiBird merged 2 commits intoMegaMek:masterfrom IllianiBird:AdminStrainNagNew
IllianiBird merged 2 commits intoMegaMek:masterfrom
IllianiBird:AdminStrainNagNew
Conversation
- Refactored `AdminStrainNagDialog` to use `ImmersiveDialogSimple` for a more modular and customizable dialog implementation. - Replaced `AbstractMHQNagDialog` inheritance with a standalone class implementation to streamline functionality. - Updated `NagController` to account for `AdminStrainNagDialog`'s restructuring, specifically replacing `wasAdvanceDayCanceled()` with `shouldCancelAdvanceDay()`. - Added Glossary entry for Admin Strain
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6376 +/- ##
============================================
- Coverage 11.32% 11.32% -0.01%
+ Complexity 6284 6283 -1
============================================
Files 1070 1070
Lines 136003 136029 +26
Branches 21016 21019 +3
============================================
- Hits 15402 15401 -1
- Misses 119057 119081 +24
- Partials 1544 1547 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjhancock
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AdminStrainNagDialogto useImmersiveDialogSimplefor a more modular and customizable dialog implementation.AbstractMHQNagDialoginheritance with a standalone class implementation to streamline functionality.NagControllerto account forAdminStrainNagDialog's restructuring, specifically replacingwasAdvanceDayCanceled()withshouldCancelAdvanceDay().