Fixed MekHQ Lockup Caused by Consecutive Glossary Dialogs; Fixed Scroll Pane Start Position in Glossary Dialogs#6378
Merged
IllianiBird merged 1 commit intoMegaMek:masterfrom Mar 24, 2025
IllianiBird:glossaryUpdate
Merged
Fixed MekHQ Lockup Caused by Consecutive Glossary Dialogs; Fixed Scroll Pane Start Position in Glossary Dialogs#6378IllianiBird merged 1 commit intoMegaMek:masterfrom IllianiBird:glossaryUpdate
IllianiBird merged 1 commit intoMegaMek:masterfrom
IllianiBird:glossaryUpdate
Conversation
…ence in Progressive Dialogs - Ensured the GlossaryDialog's scroll pane defaults to the top position on load. - Corrected `handleImmersiveHyperlinkClick` to use the correct reference (`this` instead of `parent`).
IllianiBird
added
Bug
GUI
Severity: High
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6378 +/- ##
============================================
- Coverage 11.32% 11.32% -0.01%
+ Complexity 6284 6280 -4
============================================
Files 1070 1070
Lines 136003 136004 +1
Branches 21016 21016
============================================
- Hits 15402 15397 -5
- Misses 119057 119060 +3
- Partials 1544 1547 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjhancock
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handleImmersiveHyperlinkClickto use the correct reference (thisinstead ofparent).Dev Notes
Regarding the second point, basically if a user clicks on a hyperlink inside a glossary dialog it should trigger a second dialog to appear, fading away the previous until the current is discarded. However, I was incorrectly hooking into 'parent' and not the current glossary dialog. This meant when consecutive dialogs were opened the original dialog was rendered visible/hidden, causing MekHQ to lock-up entirely.