Added New Glossary Entries for Nag Terms#6379
Merged
IllianiBird merged 4 commits intoMegaMek:masterfrom Mar 25, 2025
IllianiBird:glossaryEntriesFromNags
Merged
Added New Glossary Entries for Nag Terms#6379IllianiBird merged 4 commits intoMegaMek:masterfrom IllianiBird:glossaryEntriesFromNags
IllianiBird merged 4 commits intoMegaMek:masterfrom
IllianiBird:glossaryEntriesFromNags
Conversation
- Expanded `Glossary.properties` with new entries for Administrative Strain, Management Skill, and Turnover.
rjhancock
approved these changes
Mar 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6379 +/- ##
============================================
- Coverage 11.32% 11.31% -0.01%
+ Complexity 6284 6278 -6
============================================
Files 1070 1070
Lines 136003 136052 +49
Branches 21016 21018 +2
============================================
- Hits 15399 15392 -7
- Misses 119060 119116 +56
Partials 1544 1544 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Glossary.propertieswith new entries for Administrative Strain, Management Skill, and Turnover.Dev Notes
This PR will be updated as I move through the various nag dialogs, updating them for 50.05. I'm going to mark it as draft until I've finished updating all the nags, though this may result in some broken glossary hyperlinks. A broken hyperlink will just not trigger anything, so I decided this approach was better than constantly needing to fix conflicts in
Glossary.propertiesor submitting updates to all 17 nag dialogs in a single PR.