Updated Deployment Shortfall Nag To Use Immersive Dialog#6382
Merged
IllianiBird merged 4 commits intoMegaMek:masterfrom Mar 24, 2025
IllianiBird:DeploymentShortfallNagDialogNew
Merged
Updated Deployment Shortfall Nag To Use Immersive Dialog#6382IllianiBird merged 4 commits intoMegaMek:masterfrom IllianiBird:DeploymentShortfallNagDialogNew
IllianiBird merged 4 commits intoMegaMek:masterfrom
IllianiBird:DeploymentShortfallNagDialogNew
Conversation
- Refactored `DeploymentShortfallNagDialog` to utilize `ImmersiveDialogSimple` for improved modularity and customization. - Replaced inheritance from `AbstractMHQNagDialog` with a standalone class to simplify and streamline the implementation. - Updated NagController logic to replace `wasAdvanceDayCanceled()` with `shouldCancelAdvanceDay()` to reflect the updated behavior.
…rty for improved clarity and grammar.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6382 +/- ##
============================================
- Coverage 11.32% 11.31% -0.01%
Complexity 6280 6280
============================================
Files 1070 1070
Lines 136004 136052 +48
Branches 21016 21018 +2
============================================
Hits 15397 15397
- Misses 119060 119111 +51
+ Partials 1547 1544 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…OYMENT` in suppress action.
rjhancock
approved these changes
Mar 24, 2025
- Changed exception messages in `AdminStrainNagDialog` and `DeploymentShortfallNagDialog` to include the class name dynamically using `getClass().getSimpleName()`. - Enhances error clarity by specifying the exact dialog class in the exception output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeploymentShortfallNagDialogto utilizeImmersiveDialogSimplefor improved modularity and customization.AbstractMHQNagDialogwith a standalone class to simplify and streamline the implementation.wasAdvanceDayCanceled()withshouldCancelAdvanceDay()to reflect the updated behavior.