Updated Contract End Nag To Use Immersive Dialog#6383
Merged
IllianiBird merged 2 commits intoMegaMek:masterfrom Mar 24, 2025
IllianiBird:EndContractNagDialogNew
Merged
Updated Contract End Nag To Use Immersive Dialog#6383IllianiBird merged 2 commits intoMegaMek:masterfrom IllianiBird:EndContractNagDialogNew
IllianiBird merged 2 commits intoMegaMek:masterfrom
IllianiBird:EndContractNagDialogNew
Conversation
- Refactored `EndContractNagDialog` to utilize `ImmersiveDialogSimple` for improved modularity and customization. - Replaced inheritance from `AbstractMHQNagDialog` with a standalone class to simplify and streamline the implementation. - Updated NagController logic to replace `wasAdvanceDayCanceled()` with `shouldCancelAdvanceDay()` to reflect the updated behavior.
# Conflicts: # MekHQ/resources/mekhq/resources/NagDialogs.properties
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6383 +/- ##
============================================
- Coverage 11.31% 11.31% -0.01%
Complexity 6280 6280
============================================
Files 1070 1070
Lines 136052 136072 +20
Branches 21018 21018
============================================
- Hits 15397 15393 -4
- Misses 119111 119134 +23
- Partials 1544 1545 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjhancock
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EndContractNagDialogto utilizeImmersiveDialogSimplefor improved modularity and customization.AbstractMHQNagDialogwith a standalone class to simplify and streamline the implementation.wasAdvanceDayCanceled()withshouldCancelAdvanceDay()to reflect the updated behavior.