Updated Insufficient Astechs Nag To Use Immersive Dialog#6384
Merged
IllianiBird merged 3 commits intoMegaMek:masterfrom Mar 24, 2025
IllianiBird:InsufficientAstechsNagDialogNew
Merged
Updated Insufficient Astechs Nag To Use Immersive Dialog#6384IllianiBird merged 3 commits intoMegaMek:masterfrom IllianiBird:InsufficientAstechsNagDialogNew
IllianiBird merged 3 commits intoMegaMek:masterfrom
IllianiBird:InsufficientAstechsNagDialogNew
Conversation
- Refactored `InsufficientAstechsNagDialog` to utilize `ImmersiveDialogSimple` for improved modularity and customization. - Replaced inheritance from `AbstractMHQNagDialog` with a standalone class to simplify and streamline the implementation. - Updated NagController logic to replace `wasAdvanceDayCanceled()` with `shouldCancelAdvanceDay()` to reflect the updated behavior.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6384 +/- ##
=========================================
Coverage 11.31% 11.31%
- Complexity 6284 6285 +1
=========================================
Files 1070 1070
Lines 136110 136146 +36
Branches 21024 21029 +5
=========================================
+ Hits 15400 15407 +7
- Misses 119163 119192 +29
Partials 1547 1547 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjhancock
approved these changes
Mar 24, 2025
# Conflicts: # MekHQ/resources/mekhq/resources/GUI.properties # MekHQ/resources/mekhq/resources/NagDialogs.properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InsufficientAstechsNagDialogto utilizeImmersiveDialogSimplefor improved modularity and customization.AbstractMHQNagDialogwith a standalone class to simplify and streamline the implementation.wasAdvanceDayCanceled()withshouldCancelAdvanceDay()to reflect the updated behavior.