Adjusted Glossary Dialog Dimensions#6386
Merged
IllianiBird merged 1 commit intoMegaMek:masterfrom Mar 24, 2025
IllianiBird:glossaryDialogSize
Merged
Adjusted Glossary Dialog Dimensions#6386IllianiBird merged 1 commit intoMegaMek:masterfrom IllianiBird:glossaryDialogSize
IllianiBird merged 1 commit intoMegaMek:masterfrom
IllianiBird:glossaryDialogSize
Conversation
- Increased `CENTER_WIDTH` from 400 to 800 for improved usability and readability. - Increased `CENTER_HEIGHT` from 300 to 400 for better display of glossary content.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6386 +/- ##
============================================
- Coverage 11.31% 11.31% -0.01%
+ Complexity 6280 6279 -1
============================================
Files 1070 1070
Lines 136052 136052
Branches 21018 21018
============================================
- Hits 15397 15393 -4
- Misses 119111 119114 +3
- Partials 1544 1545 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjhancock
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CENTER_WIDTHfrom 400 to 800 for improved usability and readability.CENTER_HEIGHTfrom 300 to 400 for better display of glossary content.Dev Notes
Some of the glossary entries are quite large, so I opted to increase the dialog size to better accommodate them.