Added Award Icons to the custom User Directory #6529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved the award icon directory path to a constant in `MHQConstants` for better maintainability and to eliminate hardcoded paths. - Updated `MHQStaticDirectoryManager` to use the new constant for award icons directory management. - Improved directory initialization logic to include merging of user-defined award icon directories when available.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6529 +/- ##
============================================
- Coverage 11.28% 11.27% -0.01%
+ Complexity 6321 6319 -2
============================================
Files 1080 1080
Lines 137543 137533 -10
Branches 21300 21296 -4
============================================
- Hits 15517 15510 -7
+ Misses 120473 120470 -3
Partials 1553 1553 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IllianiBird
changed the title
rjhancock
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MHQConstantsfor better maintainability and to eliminate hardcoded paths.MHQStaticDirectoryManagerto use the new constant for award icons directory management.Fix #5309