Issue 6560: Fix for negative temporary prisoner capacity

[goron111]

Fix for #6560

• prevent temporaryPrisonerCapacity from going below MINIMUM_TEMPORARY_CAPACITY
  negative values should not be possible at all, but with 0% it would still be
  impossible to contain the prisoners with any number of additional forces.
• MINIMUM_TEMPORARY_CAPACITY = 25 (25% normal prisoner capacity)
  is an arbitrary number. I tried to balance being able to recover from an bad event
  and being to easy to recove. This value should be subject to further testing
• Changed the formular for degreeOfChange so that a lower value for temporaryPrisonerCapacity
  is not slower degrading than a higher temporaryPrisonerCapacity
• Updated the UnitTest to reflect the changes in degreeOfChange

[IllianiCBT]

Hi, please update the PR description with a brief summary of the changes you made and (ideally) why. It'll make reviewing a lot easier and means if users click on the PR number in the change log they don't need to understand Java to know what changes were made.

[IllianiCBT]

Also, sorry for the comment spam, but you really want to be making changes in a working branch and not master. Master should be kept 'pure' at all times.

[IllianiCBT]

Ignore my last comment. I'm pre-coffee and apparently woke up dumb.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.57%. Comparing base (e0ebe3a) to head (0d4959b).
Report is 24 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##             master    #6567    +/-   ##
==========================================
  Coverage     11.57%   11.57%            
- Complexity     6401     6402     +1     
==========================================
  Files          1085     1085            
  Lines        139499   139604   +105     
  Branches      21514    21532    +18     
==========================================
+ Hits          16149    16166    +17     
- Misses       121776   121868    +92     
+ Partials       1574     1570     -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[IllianiCBT]

Thanks for taking a look at this. It was on my TODO, but I'm not sure I'd have done as thorough a job, so great work. :)

If you can update the PR description that would be fantastic. But otherwise, nothing stopping this from being merged.