Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Clone Method fixes. #6571

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

rjhancock
Copy link
Collaborator

@rjhancock rjhancock commented Apr 6, 2025

This fixes the "No Clone Methods" listed under the CodeQL security tabs on MegaMek and is related to the 2 inner classes to be outer classes due to being used outside of the parent classes.

General IDEA Clean up as well.

Requires MegaMek#6836 before merging.

Copy link

codecov bot commented Apr 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.58%. Comparing base (e0ebe3a) to head (6c99899).
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##             master    #6571    +/-   ##
==========================================
  Coverage     11.57%   11.58%            
- Complexity     6401     6402     +1     
==========================================
  Files          1085     1085            
  Lines        139499   139604   +105     
  Branches      21514    21531    +17     
==========================================
+ Hits          16149    16170    +21     
- Misses       121776   121861    +85     
+ Partials       1574     1573     -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant