Added Randomize Traits Option For Character Creation #6572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new option to randomize traits during character creation, including Connections, Reputation, Wealth, and Unlucky scores. - Updated `CampaignOptionsDialog.properties` with labels and tooltips for the new setting. - Extended `RandomSkillPreferences` to support `randomizeTraits` with default settings and XML integration. - Modified personnel generators to calculate and assign random trait values when the option is enabled. - Added methods to the `Person` class for modifying traits with proper clamping to ensure values remain within defined limits. - Updated `AdvancementTab` to include a checkbox for enabling or disabling the new randomization feature.
IllianiCBT
added
Personnel
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6572 +/- ##
============================================
- Coverage 11.57% 11.57% -0.01%
+ Complexity 6401 6398 -3
============================================
Files 1085 1085
Lines 139499 139658 +159
Branches 21514 21541 +27
============================================
+ Hits 16149 16166 +17
- Misses 121776 121921 +145
+ Partials 1574 1571 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…aits in `PersonnelTableMouseAdapter`.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CampaignOptionsDialog.propertieswith labels and tooltips for the new setting.RandomSkillPreferencesto supportrandomizeTraitswith default settings and XML integration.Personclass for modifying traits with proper clamping to ensure values remain within defined limits.AdvancementTabto include a checkbox for enabling or disabling the new randomization feature.Dev Notes
This is the last of the random character creation features needed to finish off Traits and Attributes. While I was working on it I also adding clamping to the various Trait setters and changers to ensure they can't fall outside of expected values.