Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ATOW Toughness Rule And Updated Fatigue And Injury Logic #6574

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IllianiCBT
Copy link
Collaborator

  • Introduced the ATOW Toughness option for personnel, providing reduced fatigue gain and injury severity.
  • Updated fatigue calculation logic to account for the new Toughness option when combined with the Glass Jaw flaw.
  • Ensured Glass Jaw and Toughness cannot coexist due to their opposing effects.
  • Applied modified fatigue and injury calculations across multiple classes, including StratconRulesManager, ResolveScenarioTracker, and EventEffectsManager.
  • Refactored redundant logic and improved readability of fatigue and injury handling.
  • Updated defaultspa.xml to define ATOW Toughness attributes and prevent coexistence with Glass Jaw.

- Introduced the ATOW Toughness option for personnel, providing reduced fatigue gain and injury severity.
- Updated fatigue calculation logic to account for the new Toughness option when combined with the Glass Jaw flaw.
- Ensured Glass Jaw and Toughness cannot coexist due to their opposing effects.
- Applied modified fatigue and injury calculations across multiple classes, including `StratconRulesManager`, `ResolveScenarioTracker`, and `EventEffectsManager`.
- Refactored redundant logic and improved readability of fatigue and injury handling.
- Updated `defaultspa.xml` to define ATOW Toughness attributes and prevent coexistence with Glass Jaw.
@IllianiCBT IllianiCBT added SPA Any issue relating to SPA's. Includes Bugs and RFE Implementation of Missing Official Rule Used with the RFE tag for the implementation of missing official rule labels Apr 6, 2025
@IllianiCBT IllianiCBT self-assigned this Apr 6, 2025
Copy link

codecov bot commented Apr 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.58%. Comparing base (e0ebe3a) to head (02015a6).
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##             master    #6574    +/-   ##
==========================================
  Coverage     11.57%   11.58%            
  Complexity     6401     6401            
==========================================
  Files          1085     1085            
  Lines        139499   139648   +149     
  Branches      21514    21547    +33     
==========================================
+ Hits          16149    16175    +26     
- Misses       121776   121896   +120     
- Partials       1574     1577     +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Implementation of Missing Official Rule Used with the RFE tag for the implementation of missing official rule SPA Any issue relating to SPA's. Includes Bugs and RFE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant