Fix #4828, #6476: Updated Maintenance Handling and Tech Assignment Display #6587
+113
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored `doMaintenance` logic so that maintenance time is only deducted on the day maintenance takes place - to match current errata. - Added failure reporting when a tech lacks sufficient minutes for maintenance, with a localized message update. - Revised `Person.getDailyAvailableTechTime` to exclude maintenance time. - Updated `AssignUnitToTechMenu` to display accurate available minutes for tech assignment using recalculated logic.
IllianiCBT
added
Errata
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6587 +/- ##
============================================
- Coverage 11.43% 11.43% -0.01%
Complexity 6451 6451
============================================
Files 1087 1087
Lines 139447 139451 +4
Branches 21560 21563 +3
============================================
Hits 15944 15944
- Misses 121908 121913 +5
+ Partials 1595 1594 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doMaintenancelogic so that maintenance time is only deducted on the day maintenance takes place - to match current errata.Person.getDailyAvailableTechTimeto exclude maintenance time.AssignUnitToTechMenuto display available minutes for tech assignment using recalculated logic.Fix #4828
Fix #6476
Dev Notes
This PR does two things: one, it changes maintenance time deductions to match current errata which states that maintenance time is only deducted on the day in which the maintenance takes place. This will be a game changer, I suspect.
Second, when assigning a character to a unit you now see the amount of minutes they have available (minus time reserved for maintenance, but excluding time spent on that specific day); rather than just the amount of time reserved for maintenance. I'm not sure if this is the best implementation, but we had an issue report requesting it, so I went ahead and made the change. We can switch it out easily, should user feedback warrant it.