Skip to content

Fix #305: Added Medical Log, Assignment Log, Performance Report #6624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 12, 2025

Conversation

IllianiBird
Copy link
Collaborator

  • Centralized log handling with reusable methods like getLogPanel for consistent code structure and readability.
  • Added Medical Log, Performance Report, and Assignment Log log types
    • Medical Log contains all log entries from Advanced Medical
    • Performance Report contains all log entries related to the gaining of XP, improvement of Skills, and gaining of SPAs
    • Assignment Log contains all log entries relating to assignment to/from units and the TO&E
  • Added compatibility handlers to handle log entries from campaigns prior to the splitting of the log types. This won't be perfect as it's using String comparison, so will only work for unedited English-language log entries. As we don't currently have any non-English report entries I couldn't model off of them, so English-only.
  • All new logs have Campaign Options that can be set to make the individual logs expanded by default.

Fix #305

Before

image

After

image

- Introduced `MedicalLogEntry` management with methods for logging medical events in `MedicalLogger`.
- Modified `CampaignOptions` to include a setting to expand the medical log by default.
…or consistent code structure and readability.

- Added Performance Report, and Assignment Log log types
@IllianiBird IllianiBird added Personnel Personnel-related Issues UX User experience labels Apr 11, 2025
@IllianiBird IllianiBird self-assigned this Apr 11, 2025
@IllianiBird IllianiBird changed the title Fix #305: Fix #305: Added Medical Log, Assignment Log, Performance Report Apr 11, 2025
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 5.71992% with 956 lines in your changes missing coverage. Please review.

Project coverage is 11.41%. Comparing base (8fb44c9) to head (2e3759c).
Report is 48 commits behind head on master.

Files with missing lines Patch % Lines
MekHQ/src/mekhq/campaign/mod/am/InjuryUtil.java 2.58% 108 Missing and 5 partials ⚠️
MekHQ/src/mekhq/gui/control/EditLogControl.java 0.00% 108 Missing ⚠️
MekHQ/src/mekhq/gui/view/PersonViewPanel.java 0.00% 104 Missing ⚠️
MekHQ/src/mekhq/campaign/personnel/Person.java 4.90% 97 Missing ⚠️
MekHQ/src/mekhq/gui/adapter/TOEMouseAdapter.java 0.00% 92 Missing ⚠️
.../mekhq/gui/adapter/PersonnelTableMouseAdapter.java 0.00% 74 Missing ⚠️
MekHQ/src/mekhq/campaign/log/MedicalLogger.java 9.43% 48 Missing ⚠️
MekHQ/src/mekhq/campaign/log/ServiceLogger.java 7.84% 47 Missing ⚠️
.../src/mekhq/gui/dialog/AddOrEditLogEntryDialog.java 0.00% 47 Missing ⚠️
MekHQ/src/mekhq/campaign/log/AssignmentLogger.java 12.76% 41 Missing ⚠️
... and 14 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6624      +/-   ##
============================================
+ Coverage     11.39%   11.41%   +0.01%     
- Complexity     6471     6475       +4     
============================================
  Files          1093     1093              
  Lines        140333   140531     +198     
  Branches      21710    21792      +82     
============================================
+ Hits          15996    16037      +41     
- Misses       122732   122855     +123     
- Partials       1605     1639      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@rjhancock rjhancock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the copyright years. If they are inners moved to outers, ensure the start year matches that start of the file/existing year. If new files, start with 2025.

# Conflicts:
#	MekHQ/src/mekhq/campaign/CampaignOptions.java
# Conflicts:
#	MekHQ/src/mekhq/campaign/personnel/Person.java
@IllianiBird IllianiBird merged commit 5cdae07 into MegaMek:master Apr 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Personnel Personnel-related Issues UX User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logy Entry Clean-Up
2 participants