Fix: Fixed Recruitment Report Not Showing Rank#7269
Merged
HammerGS merged 1 commit intoMegaMek:masterfrom Jun 24, 2025
IllianiBird:recruitmentReportError
Merged
Fix: Fixed Recruitment Report Not Showing Rank#7269HammerGS merged 1 commit intoMegaMek:masterfrom IllianiBird:recruitmentReportError
HammerGS merged 1 commit intoMegaMek:masterfrom
IllianiBird:recruitmentReportError
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7269 +/- ##
=========================================
Coverage 12.73% 12.74%
- Complexity 7514 7517 +3
=========================================
Files 1146 1146
Lines 147363 147341 -22
Branches 22501 22500 -1
=========================================
+ Hits 18773 18779 +6
+ Misses 126580 126552 -28
Partials 2010 2010 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the recruitment report message so that it now correctly shows a character's rank along with their name.
- Changed the method call from getHyperlinkedName() to getHyperlinkedFullTitle() within the recruitment report message construction.
HammerGS
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the message reported when a character joins the campaign to show the character's rank as well as their name