Skip to content

Fix: Fixed Recruitment Report Not Showing Rank#7269

Merged
HammerGS merged 1 commit intoMegaMek:masterfrom
IllianiBird:recruitmentReportError
Jun 24, 2025
Merged

Fix: Fixed Recruitment Report Not Showing Rank#7269
HammerGS merged 1 commit intoMegaMek:masterfrom
IllianiBird:recruitmentReportError

Conversation

@IllianiBird
Copy link
Collaborator

This fixes the message reported when a character joins the campaign to show the character's rank as well as their name

@IllianiBird IllianiBird self-assigned this Jun 22, 2025
@IllianiBird IllianiBird added the Personnel Personnel-related Issues label Jun 22, 2025
@IllianiBird IllianiBird requested a review from a team as a code owner June 22, 2025 20:27
@IllianiBird IllianiBird added GUI Severity: Low Issues described as low severity as per the new issue form labels Jun 22, 2025
@codecov
Copy link

codecov bot commented Jun 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 12.74%. Comparing base (f4e2da1) to head (ac56cb0).
Report is 71 commits behind head on master.

Files with missing lines Patch % Lines
MekHQ/src/mekhq/campaign/Campaign.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #7269   +/-   ##
=========================================
  Coverage     12.73%   12.74%           
- Complexity     7514     7517    +3     
=========================================
  Files          1146     1146           
  Lines        147363   147341   -22     
  Branches      22501    22500    -1     
=========================================
+ Hits          18773    18779    +6     
+ Misses       126580   126552   -28     
  Partials       2010     2010           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HammerGS HammerGS requested review from HammerGS and Copilot June 24, 2025 00:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes the recruitment report message so that it now correctly shows a character's rank along with their name.

  • Changed the method call from getHyperlinkedName() to getHyperlinkedFullTitle() within the recruitment report message construction.

@HammerGS HammerGS merged commit 0bbb030 into MegaMek:master Jun 24, 2025
7 checks passed
@IllianiBird IllianiBird deleted the recruitmentReportError branch July 12, 2025 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GUI Personnel Personnel-related Issues Severity: Low Issues described as low severity as per the new issue form

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants