Skip to content

Fix #8428: It Is No Longer Possible to Jump Travel With Jump Incapable Units Such as Some Space Stations#8502

Merged
IllianiBird merged 3 commits intoMegaMek:mainfrom
IllianiBird:jumpLimitations
Dec 14, 2025
Merged

Fix #8428: It Is No Longer Possible to Jump Travel With Jump Incapable Units Such as Some Space Stations#8502
IllianiBird merged 3 commits intoMegaMek:mainfrom
IllianiBird:jumpLimitations

Conversation

@IllianiBird
Copy link
Collaborator

@IllianiBird IllianiBird commented Dec 14, 2025

See Also Task: Updated Description of K-F Adaptor & Modular Space Station Options

Fix #8428

If the player attempts to jump travel while the campaign contains non-jump capable units (such as damaged JumpShips or non-jump capable Space Stations) they will receive a blocker dialog. The player can cancel the jump, ignore the restriction (GM), or abandon the affected units.

If the player abandons or sells the affected units they will get a confirmation dialog to make sure they really want to do that.

Mothballing the affected unit will not prevent this blocker.

@IllianiBird IllianiBird self-assigned this Dec 14, 2025
@IllianiBird IllianiBird requested a review from a team as a code owner December 14, 2025 01:21
@IllianiBird IllianiBird added Implementation of Missing Official Rule Used with the RFE tag for the implementation of missing official rule Bug Severity: Low Issues described as low severity as per the new issue form labels Dec 14, 2025
@codecov
Copy link

codecov bot commented Dec 14, 2025

Codecov Report

❌ Patch coverage is 14.63415% with 70 lines in your changes missing coverage. Please review.
✅ Project coverage is 12.25%. Comparing base (cee6d1d) to head (8b526da).
⚠️ Report is 54 commits behind head on main.

Files with missing lines Patch % Lines
...kHQ/src/mekhq/campaign/utilities/JumpBlockers.java 18.18% 49 Missing and 5 partials ⚠️
MekHQ/src/mekhq/gui/dialog/MHQOptionsDialog.java 0.00% 12 Missing ⚠️
...aign/market/contractMarket/ContractAutomation.java 0.00% 2 Missing ⚠️
MekHQ/src/mekhq/gui/MapTab.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8502   +/-   ##
=========================================
  Coverage     12.25%   12.25%           
- Complexity     7363     7373   +10     
=========================================
  Files          1286     1287    +1     
  Lines        165097   165194   +97     
  Branches      24823    24847   +24     
=========================================
+ Hits          20227    20247   +20     
- Misses       142948   143016   +68     
- Partials       1922     1931    +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@psikomonkie psikomonkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@IllianiBird IllianiBird merged commit 6cdc9e4 into MegaMek:main Dec 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Implementation of Missing Official Rule Used with the RFE tag for the implementation of missing official rule Severity: Low Issues described as low severity as per the new issue form

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Issue] Able to jump with Space Station

2 participants