Fix: Fixed Space Station Transport Requirements Using Wrong Getter#8518
Fix: Fixed Space Station Transport Requirements Using Wrong Getter#8518HammerGS merged 2 commits intoMegaMek:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the wrong getter method was being called on SpaceStation objects when calculating transport collar requirements. The code was incorrectly calling getTonnage() instead of getWeight() on Entity objects.
Key Changes:
- Corrected method call from
spaceStation.getTonnage()tospaceStation.getWeight()for proper weight calculation in collar requirement logic
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8518 +/- ##
============================================
+ Coverage 12.25% 12.28% +0.03%
- Complexity 7370 7400 +30
============================================
Files 1286 1287 +1
Lines 165132 165298 +166
Branches 24832 24875 +43
============================================
+ Hits 20239 20314 +75
- Misses 142967 143045 +78
- Partials 1926 1939 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
psikomonkie
left a comment
There was a problem hiding this comment.
This wasn't causing any issues, right? Just cleaning it up?
|
I don't think it was causing any issues. |
spaceStation.getTonnage->spaceStation.getWeight