Skip to content

Issue MegaMek/mekhq#8427: Prevent array index OOB from troop size and issue with docking collar assignment in MekHQ#8524

Merged
psikomonkie merged 2 commits intoMegaMek:mainfrom
psikomonkie:issue/8427/space-station-docking-collar
Dec 15, 2025
Merged

Issue MegaMek/mekhq#8427: Prevent array index OOB from troop size and issue with docking collar assignment in MekHQ#8524
psikomonkie merged 2 commits intoMegaMek:mainfrom
psikomonkie:issue/8427/space-station-docking-collar

Conversation

@psikomonkie
Copy link
Member

Fixes #8427 once MegaMek/megamek#7787 is also merged.

This fixes issues with assigning drop ships to a space station's docking collars.

@psikomonkie psikomonkie requested a review from a team as a code owner December 14, 2025 22:53
@codecov
Copy link

codecov bot commented Dec 14, 2025

Codecov Report

❌ Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 12.29%. Comparing base (db9e627) to head (ac1e50d).
⚠️ Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
...khq/campaign/unit/ShipTransportedUnitsSummary.java 0.00% 16 Missing ⚠️
...c/mekhq/campaign/unit/TransportShipAssignment.java 0.00% 10 Missing ⚠️
...campaign/utilities/CampaignTransportUtilities.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8524   +/-   ##
=========================================
  Coverage     12.29%   12.29%           
- Complexity     7401     7402    +1     
=========================================
  Files          1287     1287           
  Lines        165298   165315   +17     
  Branches      24875    24884    +9     
=========================================
+ Hits          20317    20321    +4     
- Misses       143041   143053   +12     
- Partials       1940     1941    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@psikomonkie psikomonkie merged commit f7edade into MegaMek:main Dec 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Issue] Space Station dockin Array Index Out of Bound exception

2 participants