Issue MegaMek/mekhq#8427: Prevent array index OOB from troop size and issue with docking collar assignment in MekHQ#8524
Merged
psikomonkie merged 2 commits intoMegaMek:mainfrom Dec 15, 2025
Conversation
… with docking collar assignment in MekHQ
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8524 +/- ##
=========================================
Coverage 12.29% 12.29%
- Complexity 7401 7402 +1
=========================================
Files 1287 1287
Lines 165298 165315 +17
Branches 24875 24884 +9
=========================================
+ Hits 20317 20321 +4
- Misses 143041 143053 +12
- Partials 1940 1941 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IllianiBird
approved these changes
Dec 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8427 once MegaMek/megamek#7787 is also merged.
This fixes issues with assigning drop ships to a space station's docking collars.