Fixed maneuver/auxillary reinforcement roll reporting#8709
Merged
Sleet01 merged 2 commits intoMegaMek:mainfrom Jan 30, 2026
Merged
Fixed maneuver/auxillary reinforcement roll reporting#8709Sleet01 merged 2 commits intoMegaMek:mainfrom
Sleet01 merged 2 commits intoMegaMek:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8709 +/- ##
============================================
- Coverage 13.07% 13.07% -0.01%
+ Complexity 7788 7787 -1
============================================
Files 1306 1306
Lines 168988 168988
Branches 25398 25398
============================================
- Hits 22091 22087 -4
- Misses 144771 144773 +2
- Partials 2126 2128 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Corrected line 1938 - now reports both rolls within brackets. Correct number of arguments
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes: #8640
Fixed reporting for rolls when reinforcing using maneuver or auxiliary forces. The rolls were being completed with advantage, as intended, however the string was only reporting the highest roll twice.