Merged
Conversation
Root Cause When spending XP to acquire a new skill, getSkill() returns null before the skill exists. After improveSkill() creates the skill, the local skill variable was never updated, causing a NullPointerException when accessing skill.getType() and skill.getLevel(). Changes 1. PersonnelTableMouseAdapter.java - Re-fetch the skill after improveSkill() creates it Files Changed - MekHQ/src/mekhq/gui/adapter/PersonnelTableMouseAdapter.java - Added skill re-fetch after creation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the personnel skill improvement flow so that logging and reporting operate on the updated skill state, likely addressing an issue surfaced by the “learning ropes” campaign scenario.
Changes:
- After improving a skill and spending XP, re-fetches the
Skillobject from the selected person to ensure subsequent logging uses the post-improvement skill instance.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.