Fixed Eagle Eyes rolls for Advanced Scouting#8751
Fixed Eagle Eyes rolls for Advanced Scouting#8751heckindoc wants to merge 3 commits intoMegaMek:mainfrom
Conversation
… more difficult Ammended because I missed one instance of eagle eyes (for vehicles. oops)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8751 +/- ##
============================================
- Coverage 13.14% 13.13% -0.01%
+ Complexity 7828 7826 -2
============================================
Files 1306 1306
Lines 169092 169092
Branches 25422 25422
============================================
- Hits 22220 22208 -12
- Misses 144732 144743 +11
- Partials 2140 2141 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| options.booleanOption(OptionsConstants.MISC_EAGLE_EYES) ? | ||
| 1 : 0; | ||
| -1 : 0; | ||
|
|
||
| int scoutSkillLevel = (scoutSkill == null) ? -1 : scoutSkill.getTotalSkillLevel(skillModifierData); |
There was a problem hiding this comment.
For this specific usage, is lower better or worse & should eagle eyes be a bonus or penalty?
The other usage is a TN, lower is better, all good.
This usage looks like lower is worse - this value will be added to scoutSkillLevel, which defaults to -1 if the skill isn't found.
I believe the eagle eyes value here should still be positive if it's meant to be a bonus.
There was a problem hiding this comment.
Eagle Eyes functions in the same fashion as a beagle probe in the setting of Advanced Scouting, decreasing the TN by 1.
In testing on 50.11, Eagle Eyes increased the TN by 1 and when made negative and retested in the 50.12 environment Eagle Eyes then had the intended effect of reducing the TN by 1.
There was a problem hiding this comment.
Changing "1" to "-1" for the TN is correct, I agree.
I don't think this specific usage is for a TN though.
EDIT: This is for determining the best scout. It calculates their effective skill level, a positive value, and returns whoever has the highest value. This change will cause persons with Eagle Eye to be considered worse than they are.
There was a problem hiding this comment.
I'll try to take another look at it tonight and test it further and/or see if I can find a different solution. Thank you!
|
I'm going to close this PR. The problem is happening somewhere else. I'll keep looking and when I get a solution I'll submit another PR. Thank you. |
2 participants
There was a missing negative sign, I added the negative and now eagle eyes does what it is supposed to do