Skip to content

ci: update dra-driver-sriov version to 832f007 (of branch network-operator-26.4.x)#2251

Open
nvidia-ci-cd wants to merge 1 commit intomasterfrom
ci/update-dra-driver-sriov-version-to-832f007
Open

ci: update dra-driver-sriov version to 832f007 (of branch network-operator-26.4.x)#2251
nvidia-ci-cd wants to merge 1 commit intomasterfrom
ci/update-dra-driver-sriov-version-to-832f007

Conversation

@nvidia-ci-cd
Copy link
Collaborator

Automated CI update for component 'dra-driver-sriov', created by GitHub actions reusable workflow run 22930275707 for release branch network-operator-26.4.x.

Signed-off-by: nvidia-ci-cd <svc-cloud-orch-gh@nvidia.com>
@greptile-apps
Copy link

greptile-apps bot commented Mar 11, 2026

Greptile Summary

This PR is an automated CI update that bumps the DraDriverSriov component version in hack/release.yaml from network-operator-v26.1.0 to 832f007 (a short Git commit SHA from the network-operator-26.4.x branch).

Key observations:

  • The change is minimal — a single version string update in hack/release.yaml.
  • All other components in release.yaml use semantic version tags (e.g., network-operator-v26.1.0), making this commit SHA the only exception and inconsistent with the established versioning convention.
  • Using a bare 7-character commit SHA instead of a tagged release makes it harder to audit, could be ambiguous, and may not reflect a stable release artifact. Ideally this should be updated to a proper semantic tag before landing on master.

Confidence Score: 3/5

  • Functionally low-risk version bump, but the use of a bare commit SHA instead of a semantic version tag is inconsistent with the rest of the file and warrants clarification before merging to master.
  • The change itself is a one-line version update with no code logic changes. However, the new value 832f007 is a short commit SHA rather than a tagged release, which deviates from every other component's versioning convention in the same file. This warrants a lower confidence score pending confirmation that this is intentional or that a proper tag will be cut.
  • hack/release.yaml — the DraDriverSriov version value should ideally use a semantic tag consistent with other components.

Important Files Changed

Filename Overview
hack/release.yaml Bumps DraDriverSriov version from network-operator-v26.1.0 to a bare commit SHA 832f007, which is inconsistent with all other components using semantic version tags in this file.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[CI Workflow\ndra-driver-sriov\nnetwork-operator-26.4.x] -->|Automated update| B[hack/release.yaml\nDraDriverSriov.version]
    B -->|Before| C[network-operator-v26.1.0\nSemantic tag]
    B -->|After| D[832f007\nCommit SHA]
    D -->|Inconsistency| E[All other components\nuse semantic version tags]
Loading

Last reviewed commit: 27fc4c0

repository: nvcr.io/nvstaging/mellanox
sourceRepository: dra-driver-sriov
version: network-operator-v26.1.0
version: 832f007
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit SHA used instead of a semantic version tag

All other components in this file use semantic version tags (e.g., network-operator-v26.1.0), but DraDriverSriov is being set to a bare 7-character Git commit SHA (832f007). This diverges from the established versioning convention used by every other entry in release.yaml.

Using a short commit SHA introduces several concerns:

  • It is ambiguous — short SHAs can collide across repositories, and the referenced commit may not point to a stable, tagged release.
  • It is harder to audit/track in release notes or changelogs compared to a named version.
  • It is inconsistent with the rest of the manifest, which could cause confusion for release tooling that expects a uniform version format.

Was a proper release tag (e.g., network-operator-v26.4.x-...) not yet available for this commit? If this is intentional for pre-release testing, it should ideally be updated to a tagged version before merging into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant