ci: update dra-driver-sriov version to 832f007 (of branch network-operator-26.4.x)#2251
ci: update dra-driver-sriov version to 832f007 (of branch network-operator-26.4.x)#2251nvidia-ci-cd wants to merge 1 commit intomasterfrom
Conversation
Signed-off-by: nvidia-ci-cd <svc-cloud-orch-gh@nvidia.com>
Greptile SummaryThis PR is an automated CI update that bumps the Key observations:
Confidence Score: 3/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[CI Workflow\ndra-driver-sriov\nnetwork-operator-26.4.x] -->|Automated update| B[hack/release.yaml\nDraDriverSriov.version]
B -->|Before| C[network-operator-v26.1.0\nSemantic tag]
B -->|After| D[832f007\nCommit SHA]
D -->|Inconsistency| E[All other components\nuse semantic version tags]
Last reviewed commit: 27fc4c0 |
| repository: nvcr.io/nvstaging/mellanox | ||
| sourceRepository: dra-driver-sriov | ||
| version: network-operator-v26.1.0 | ||
| version: 832f007 |
There was a problem hiding this comment.
Commit SHA used instead of a semantic version tag
All other components in this file use semantic version tags (e.g., network-operator-v26.1.0), but DraDriverSriov is being set to a bare 7-character Git commit SHA (832f007). This diverges from the established versioning convention used by every other entry in release.yaml.
Using a short commit SHA introduces several concerns:
- It is ambiguous — short SHAs can collide across repositories, and the referenced commit may not point to a stable, tagged release.
- It is harder to audit/track in release notes or changelogs compared to a named version.
- It is inconsistent with the rest of the manifest, which could cause confusion for release tooling that expects a uniform version format.
Was a proper release tag (e.g., network-operator-v26.4.x-...) not yet available for this commit? If this is intentional for pre-release testing, it should ideally be updated to a tagged version before merging into master.
Automated CI update for component 'dra-driver-sriov', created by GitHub actions reusable workflow run 22930275707 for release branch network-operator-26.4.x.