Skip to content

ci: update dra-driver-sriov version to 832f007 (of branch network-operator-26.4.x) #2251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nvidia-ci-cd wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ci: update dra-driver-sriov version to 832f007 (of branch network-operator-26.4.x) #2251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hack/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,5 +198,5 @@ DraDriverSriov:
image: dra-driver-sriov
repository: nvcr.io/nvstaging/mellanox
sourceRepository: dra-driver-sriov
version: network-operator-v26.1.0
version: 832f007
Copy link

@greptile-apps greptile-apps bot Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit SHA used instead of a semantic version tag

All other components in this file use semantic version tags (e.g., network-operator-v26.1.0), but DraDriverSriov is being set to a bare 7-character Git commit SHA (832f007). This diverges from the established versioning convention used by every other entry in release.yaml.

Using a short commit SHA introduces several concerns:

  • It is ambiguous — short SHAs can collide across repositories, and the referenced commit may not point to a stable, tagged release.
  • It is harder to audit/track in release notes or changelogs compared to a named version.
  • It is inconsistent with the rest of the manifest, which could cause confusion for release tooling that expects a uniform version format.

Was a proper release tag (e.g., network-operator-v26.4.x-...) not yet available for this commit? If this is intentional for pre-release testing, it should ideally be updated to a tagged version before merging into master.

nSpectScope: gov-ready
Loading