Use magrittr pipe exclusively in examples for consistency #517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
R CMD build
results for R-devel now include the following warning:This is because we have started to use the native pipe
|>
in some of the examples, but theDESCRIPTION
continues to only require R >=3.5:gsDesign2/DESCRIPTION
Line 37 in d0a5897
Given that {gsDesign2} depends on dplyr and imports the magrittr pipe (
%>%
) into the package namespace, I think it makes sense to continue to use the magritter pipe for now:gsDesign2/NAMESPACE
Line 68 in d0a5897
At some point we'll want to migrate the entire package to use the native pipe
|>
, but at this point I don't think this is urgently needed.Background:
R CMD check
does not flag this code as problematic)