chore: add name and state properties to SnapKeyring to support modular initialisation#379
Merged
Merged
Conversation
… initialisation
Mrtenz
changed the title
name and state properties to SnapKeyring to support modular initialisationname and state properties to SnapKeyring to support modular initialisation
Mrtenz
commented
Sep 19, 2025
ccharly
reviewed
Sep 19, 2025
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
ccharly
previously approved these changes
Sep 19, 2025
Mrtenz
enabled auto-merge
September 19, 2025 11:40
ccharly
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
nameandstateproperty toSnapKeyring. The name is set to the TypeScript literal "SnapKeyring" and the state is alwaysnull. These properties are required for modular initialisation in the clients. Blocking MetaMask/metamask-extension#35987.