Skip to content

feat(keyring-api): add token approval type#537

Merged
hmalik88 merged 4 commits into
mainfrom
hm/update-transaction-type
Apr 29, 2026
Merged

feat(keyring-api): add token approval type#537
hmalik88 merged 4 commits into
mainfrom
hm/update-transaction-type

Conversation

@hmalik88

@hmalik88 hmalik88 commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

This adds a token approval type to TransactionType and subsequently TransactionStruct. The change was made as it is needed to make the distinction for transaction type in the UI, otherwise we see "Interaction"


Note

Low Risk
Small additive change to an enum and its struct validation; risk is limited to downstream consumers needing to handle the new transaction type string.

Overview
Adds a new TransactionType.TokenApprove (token:approve) variant to represent ERC-20/asset approval transactions.

Updates TransactionStruct validation to accept the new type, and documents the addition in the keyring-api changelog under Unreleased.

Reviewed by Cursor Bugbot for commit 785d6b5. Bugbot is set up for automated code reviews on this repo. Configure here.

@hmalik88 hmalik88 marked this pull request as ready for review April 29, 2026 13:12
@hmalik88 hmalik88 requested a review from a team as a code owner April 29, 2026 13:12
Comment thread packages/keyring-api/src/api/transaction.ts Outdated
@ccharly ccharly changed the title feat: add token approval type feat(keyring-api): add token approval type Apr 29, 2026
@hmalik88 hmalik88 enabled auto-merge April 29, 2026 16:05
@hmalik88 hmalik88 added this pull request to the merge queue Apr 29, 2026
Merged via the queue into main with commit 27360d5 Apr 29, 2026
41 checks passed
@hmalik88 hmalik88 deleted the hm/update-transaction-type branch April 29, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants