feat(keyring-api): add token approval type#537
Merged
Conversation
ccharly
reviewed
Apr 29, 2026
ccharly
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a token approval type to
TransactionTypeand subsequentlyTransactionStruct. The change was made as it is needed to make the distinction for transaction type in the UI, otherwise we see "Interaction"Note
Low Risk
Small additive change to an enum and its struct validation; risk is limited to downstream consumers needing to handle the new transaction type string.
Overview
Adds a new
TransactionType.TokenApprove(token:approve) variant to represent ERC-20/asset approval transactions.Updates
TransactionStructvalidation to accept the new type, and documents the addition in thekeyring-apichangelog under Unreleased.Reviewed by Cursor Bugbot for commit 785d6b5. Bugbot is set up for automated code reviews on this repo. Configure here.