Skip to content

feat(keyring-api): add token approval type #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hmalik88 merged 4 commits into from
Apr 29, 2026
Merged

feat(keyring-api): add token approval type #537

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
36c22e7
feat: add token approval type
hmalik88 Apr 29, 2026
2a64cdc
chore: add changelog entry
hmalik88 Apr 29, 2026
b2a946a
Merge remote-tracking branch 'origin/main' into hm/update-transaction…
hmalik88 Apr 29, 2026
785d6b5
refactor: rename enum
hmalik88 Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/keyring-api/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Added

- Add `TransactionType.Approve` for token approval transactions ([#537](https://github.com/MetaMask/accounts/pull/537))

## [23.0.1]

### Fixed
Expand Down
6 changes: 6 additions & 0 deletions packages/keyring-api/src/api/transaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,11 @@ export enum TransactionType {
*/
StakeWithdraw = 'stake:withdraw',

/**
* Represents a token approval transaction.
*/
Approve = 'token:approve',
Comment thread
hmalik88 marked this conversation as resolved.
Outdated

/**
* The transaction type is unknown. It's not possible to determine the
* transaction type based on the information available.
Expand Down Expand Up @@ -355,6 +360,7 @@ export const TransactionStruct = object({
`${TransactionType.BridgeReceive}`,
`${TransactionType.StakeDeposit}`,
`${TransactionType.StakeWithdraw}`,
`${TransactionType.Approve}`,
`${TransactionType.Unknown}`,
]),

Expand Down
Loading