feat: Implement display nft media #1893
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e info on the issue connected to the PR
…nd handle it accordingly
3 tasks
Gudahtt
reviewed
Nov 9, 2023
Gudahtt
reviewed
Nov 9, 2023
Gudahtt
reviewed
Nov 9, 2023
|
Could you update the PR to describe the error scenarios meant to be covered here? It wasn't totally clear from the linked planning issue (which seemed to be about a larger feature, not focused on error handling) i.e. What is the "display NFT media" feature, and how does this PR relate to it? What problems are these changes meant to solve? |
Gudahtt
reviewed
Nov 14, 2023
Co-authored-by: Mark Stacey <[email protected]>
Gudahtt
previously approved these changes
Nov 24, 2023
| const hasIpfsTokenURI = tokenURI.startsWith('ipfs://'); | ||
|
|
||
| if (hasIpfsTokenURI && !isIpfsGatewayEnabled) { | ||
| if (!displayNftMedia && !isIpfsGatewayEnabled) { |
There was a problem hiding this comment.
Nit: This can be removed as well, as it's covered by the next block
|
Ah, it looks like at least one test is still failing |
Co-authored-by: Mark Stacey <[email protected]>
Co-authored-by: Mark Stacey <[email protected]>
Co-authored-by: Mark Stacey <[email protected]>
…erage be reached by 0.12 percent
…erage be reached by 0.12 percent
|
Able to revert the commits that were wrong on this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
relates to: https://github.com/MetaMask/mobile-planning/issues/1166
This PR aims to solve the implementation of display nft media being a user preference.
It adds a handling error when the proxy or our third party fails, giving the possibility for the client to show a fallback image instead.
@metamask/preferences-controller@metamask/assets-controller/NftControllerThis property was added in order to register if the fetch from third parties, open sea, the chain, or our proxy fails and we can avoid keep calling to update it, avoiding a loop that way,
This error can assume the value of 'Opensea import error', 'URI import error' and 'Both import failed'.
Checklist