-
-
Notifications
You must be signed in to change notification settings - Fork 223
chore: add metadata to account controller options for EVM HD accounts #5618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…o normal-account-options
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
# Conflicts: # packages/accounts-controller/CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of NITs
Co-authored-by: Michele Esposito <[email protected]>
…e properties Co-authored-by: Charly Chevalier <[email protected]>
rerunning jobs did not work and merging the PR is blocked
Explanation
In the multi-SRP context, we need to bubble up the Account metadata such that it is available in interactions with the AccountsController.
This metadata will be used by the Backup & Sync feature to determine how to reconstruct the account when restoring from backup.
References
Fixes Identity-90
Changelog
Checklist