Skip to content

chore: add metadata to account controller options for EVM HD accounts #5618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 30, 2025

Conversation

shane-t
Copy link
Member

@shane-t shane-t commented Apr 9, 2025

Explanation

In the multi-SRP context, we need to bubble up the Account metadata such that it is available in interactions with the AccountsController.
This metadata will be used by the Backup & Sync feature to determine how to reconstruct the account when restoring from backup.

References

Fixes Identity-90

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes (extension mobile)

@shane-t
Copy link
Member Author

shane-t commented Apr 17, 2025

@metamaskbot publish-preview

@shane-t shane-t marked this pull request as ready for review April 17, 2025 10:04
@shane-t shane-t requested review from a team as code owners April 17, 2025 10:04
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "27.0.0-preview-ca400074",
  "@metamask-previews/address-book-controller": "6.0.3-preview-ca400074",
  "@metamask-previews/announcement-controller": "7.0.3-preview-ca400074",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-ca400074",
  "@metamask-previews/approval-controller": "7.1.3-preview-ca400074",
  "@metamask-previews/assets-controllers": "57.0.0-preview-ca400074",
  "@metamask-previews/base-controller": "8.0.0-preview-ca400074",
  "@metamask-previews/bridge-controller": "15.0.0-preview-ca400074",
  "@metamask-previews/bridge-status-controller": "12.0.1-preview-ca400074",
  "@metamask-previews/build-utils": "3.0.3-preview-ca400074",
  "@metamask-previews/chain-agnostic-permission": "0.3.0-preview-ca400074",
  "@metamask-previews/composable-controller": "11.0.0-preview-ca400074",
  "@metamask-previews/controller-utils": "11.7.0-preview-ca400074",
  "@metamask-previews/delegation-controller": "0.1.0-preview-ca400074",
  "@metamask-previews/earn-controller": "0.12.0-preview-ca400074",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-ca400074",
  "@metamask-previews/ens-controller": "16.0.0-preview-ca400074",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-ca400074",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-ca400074",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-ca400074",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-ca400074",
  "@metamask-previews/keyring-controller": "21.0.3-preview-ca400074",
  "@metamask-previews/logging-controller": "6.0.4-preview-ca400074",
  "@metamask-previews/message-manager": "12.0.1-preview-ca400074",
  "@metamask-previews/multichain": "4.0.0-preview-ca400074",
  "@metamask-previews/multichain-api-middleware": "0.1.1-preview-ca400074",
  "@metamask-previews/multichain-network-controller": "0.5.0-preview-ca400074",
  "@metamask-previews/multichain-transactions-controller": "0.9.0-preview-ca400074",
  "@metamask-previews/name-controller": "8.0.3-preview-ca400074",
  "@metamask-previews/network-controller": "23.2.0-preview-ca400074",
  "@metamask-previews/notification-services-controller": "6.0.0-preview-ca400074",
  "@metamask-previews/permission-controller": "11.0.6-preview-ca400074",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-ca400074",
  "@metamask-previews/phishing-controller": "12.4.1-preview-ca400074",
  "@metamask-previews/polling-controller": "13.0.0-preview-ca400074",
  "@metamask-previews/preferences-controller": "17.0.0-preview-ca400074",
  "@metamask-previews/profile-sync-controller": "12.0.0-preview-ca400074",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-ca400074",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-ca400074",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-ca400074",
  "@metamask-previews/sample-controllers": "0.1.0-preview-ca400074",
  "@metamask-previews/selected-network-controller": "22.0.0-preview-ca400074",
  "@metamask-previews/signature-controller": "27.1.0-preview-ca400074",
  "@metamask-previews/token-search-discovery-controller": "3.1.0-preview-ca400074",
  "@metamask-previews/transaction-controller": "54.1.0-preview-ca400074",
  "@metamask-previews/user-operation-controller": "33.0.0-preview-ca400074"
}

mirceanis
mirceanis previously approved these changes Apr 17, 2025
Copy link
Contributor

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

# Conflicts:
#	packages/accounts-controller/CHANGELOG.md
@mirceanis mirceanis requested a review from ccharly April 30, 2025 10:08
Copy link
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of NITs

@mirceanis mirceanis added the team-identity Identity Team changes. https://github.com/orgs/MetaMask/teams/identity label Apr 30, 2025
@mirceanis mirceanis disabled auto-merge April 30, 2025 11:35
@mirceanis mirceanis enabled auto-merge (squash) April 30, 2025 12:16
rerunning jobs did not work and merging the PR is blocked
@mirceanis mirceanis merged commit fd0c24f into main Apr 30, 2025
202 checks passed
@mirceanis mirceanis deleted the normal-account-options branch April 30, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-identity Identity Team changes. https://github.com/orgs/MetaMask/teams/identity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants