Skip to content

Conversation

@0xOhm
Copy link
Contributor

@0xOhm 0xOhm commented Jan 5, 2026

Note

Adds a new custom domain to the extended public suffix list used by tests.

  • Appends uploader.irys.xyz to customTlds in test/custom-tlds.ts
  • Minor formatting fix: trailing comma after page.gd

Written by Cursor Bugbot for commit eef4b41. This will update automatically on new commits. Configure here.

@0xOhm 0xOhm requested review from a team, 409H, FrederikBolding and kumavis as code owners January 5, 2026 21:20
"freecluster.eu",
"page.gd"
"page.gd",
"uploader.irys.xyz",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Company subdomain added instead of user content suffix

The entry uploader.irys.xyz appears to be a company-created subdomain rather than a user-generated content hosting suffix. The file comments explicitly warn: "Do not add real businesses that are using subdomains that are created by the company itself. You will enable false positives." Unlike other entries in the list (e.g., wordpress.com, gitbook.io) where users create subdomains, uploader is a fixed subdomain of irys.xyz. If the intent was to add Irys as a content hosting platform, the entry should likely be irys.xyz instead.

Fix in Cursor Fix in Web

"freecluster.eu",
"page.gd"
"page.gd",
"uploader.irys.xyz",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Domain added to conflicting lists with different semantics

The domain uploader.irys.xyz is being added to customTlds but it already exists in PATH_REQUIRED_DOMAINS. These lists have conflicting semantics: PATH_REQUIRED_DOMAINS indicates user content is accessed via paths (e.g., uploader.irys.xyz/hash), while customTlds treats the domain as a public suffix where user content is at subdomains (e.g., something.uploader.irys.xyz). Adding the same domain to both lists suggests a misunderstanding of how the service works, and the customTlds entry may be ineffective or incorrect.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants