Skip to content

Update custom-tlds.ts #214706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xOhm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update custom-tlds.ts #214706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/custom-tlds.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,5 +249,6 @@ export const customTlds = [
"infinityfreeapp.com",
"ct.ws",
"freecluster.eu",
"page.gd"
"page.gd",
"uploader.irys.xyz",
Copy link

@cursor cursor bot Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Company subdomain added instead of user content suffix

The entry uploader.irys.xyz appears to be a company-created subdomain rather than a user-generated content hosting suffix. The file comments explicitly warn: "Do not add real businesses that are using subdomains that are created by the company itself. You will enable false positives." Unlike other entries in the list (e.g., wordpress.com, gitbook.io) where users create subdomains, uploader is a fixed subdomain of irys.xyz. If the intent was to add Irys as a content hosting platform, the entry should likely be irys.xyz instead.

Fix in Cursor Fix in Web

Copy link

@cursor cursor bot Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Domain added to conflicting lists with different semantics

The domain uploader.irys.xyz is being added to customTlds but it already exists in PATH_REQUIRED_DOMAINS. These lists have conflicting semantics: PATH_REQUIRED_DOMAINS indicates user content is accessed via paths (e.g., uploader.irys.xyz/hash), while customTlds treats the domain as a public suffix where user content is at subdomains (e.g., something.uploader.irys.xyz). Adding the same domain to both lists suggests a misunderstanding of how the service works, and the customTlds entry may be ineffective or incorrect.

Fix in Cursor Fix in Web

];