feat(Snaps): Change Snap export tracking approach #31553

david0xd · 2025-04-03T09:17:40Z

Description

This PR is the next step in moving Snap export tracking away from the extension and transferring its functionality and responsibility to Snap Controller.

Notes

Requires Snaps release.
Snaps PR: feat: Add Snap export handler usage tracking snaps#3281
Targets Snaps release when ready.

Related issues

Fixes: MetaMask/snaps#3259

Manual testing steps

Find a way to verify that events are tracked (test locally, add console log, etc.)

Screenshots/Recordings

Before

n/a

After

n/a

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-04-03T09:17:53Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-04-03T09:19:25Z

✨ Files requiring CODEOWNER review ✨

🫰 @MetaMask/snaps-devs

app/scripts/controller-init/snaps/snap-controller-init.test.ts
app/scripts/controller-init/snaps/snap-controller-init.ts

metamaskbot · 2025-04-03T13:02:25Z

Builds ready [0e305f4]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1225 ± 66 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1225	1112	1421	66	1265	1371
			load	1074	963	1236	60	1141	992
			domContentLoaded	1068	959	1229	60	1157	996
			domInteractive	16	13	34	5	16	27
			firstPaint	718	126	1192	419	238	973
			backgroundConnect	9	6	33	3	9	9
			firstReactRender	19	14	46	6	19	34
			getState	10	4	27	6	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	820	717	984	59	861	926
			setupStore	7	5	16	2	7	8
	Webpack	Home	uiStartup	2153	1757	2704	237	2303	2641
			load	1674	1384	2228	196	1821	2043
			domContentLoaded	1668	1379	2224	194	1816	2021
			domInteractive	18	12	77	14	14	55
			firstPaint	198	68	385	64	246	385
			backgroundConnect	32	15	226	27	32	81
			firstReactRender	186	55	358	114	88	99
			getState	13	3	264	26	8	9
			initialActions	3	1	6	1	3	4
			loadScripts	1660	1369	2220	190	1810	1996
			setupStore	32	7	292	57	25	8
Firefox	Browserify	Home	uiStartup	1371	1184	2017	153	1407	1744
			load	1232	1052	1879	149	1270	1588
			domContentLoaded	1232	1052	1879	149	1270	1588
			domInteractive	101	40	185	29	87	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	16	59	6	25	33
			firstReactRender	22	19	47	4	22	28
			getState	6	4	25	2	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1210	1035	1857	148	1252	1555
			setupStore	6	4	59	6	6	7
	Webpack	Home	uiStartup	1603	1383	2177	176	1689	2049
			load	1384	1195	1941	166	1475	1830
			domContentLoaded	1384	1194	1941	166	1474	1829
			domInteractive	106	37	244	27	93	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	18	45	5	27	33
			firstReactRender	37	30	57	6	40	52
			getState	8	4	32	5	8	9
			initialActions	1	0	2	1	1	1
			loadScripts	1361	1176	1914	165	1451	1810
			setupStore	8	5	33	4	8	9

Bundle size diffs [🚀 Bundle size reduced!]

background: -1.01 KiB (-0.02%)
ui: -7.63 KiB (-0.11%)
common: -870 Bytes (-0.01%)

metamaskbot · 2025-04-04T12:56:58Z

Builds ready [d9d1973]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1212 ± 62 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1212	1096	1390	62	1251	1316
			load	1069	970	1249	57	1150	992
			domContentLoaded	1063	966	1230	56	1162	993
			domInteractive	16	13	34	4	15	28
			firstPaint	725	131	1239	428	234	986
			backgroundConnect	9	6	28	3	9	9
			firstReactRender	19	15	42	5	19	32
			getState	10	4	34	6	6	7
			initialActions	0	0	1	0	0	0
			loadScripts	814	716	954	55	839	923
			setupStore	7	4	13	2	7	8
	Webpack	Home	uiStartup	2118	1679	2540	169	2235	2308
			load	1647	1305	2031	129	1727	1828
			domContentLoaded	1641	1300	2027	129	1722	1824
			domInteractive	17	12	58	11	14	51
			firstPaint	163	68	363	59	240	93
			backgroundConnect	32	10	247	31	29	62
			firstReactRender	178	53	353	113	60	90
			getState	9	3	26	4	7	9
			initialActions	5	1	235	23	3	5
			loadScripts	1632	1296	2017	128	1711	1821
			setupStore	25	6	296	49	257	8
Firefox	Browserify	Home	uiStartup	1397	1221	1963	135	1453	1739
			load	1252	1069	1800	132	1301	1574
			domContentLoaded	1252	1069	1800	132	1301	1573
			domInteractive	98	40	191	25	89	95
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	17	53	7	26	37
			firstReactRender	23	19	61	5	23	29
			getState	7	4	18	2	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	1229	1048	1772	131	1283	1546
			setupStore	7	4	23	3	6	8
	Webpack	Home	uiStartup	1564	1348	2247	188	1621	2086
			load	1343	1154	1922	163	1390	1729
			domContentLoaded	1343	1154	1921	163	1389	1729
			domInteractive	95	38	163	25	90	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	18	92	9	27	45
			firstReactRender	36	29	51	5	38	47
			getState	8	4	31	4	8	9
			initialActions	1	0	1	0	1	1
			loadScripts	1320	1134	1898	162	1366	1700
			setupStore	9	5	118	12	8	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.27 KiB (0.04%)
ui: 8.79 KiB (0.13%)
common: 201 Bytes (0%)

metamaskbot · 2025-04-04T13:53:36Z

Builds ready [78ecd22]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1236 ± 65 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1236	1100	1416	65	1275	1351
			load	1085	974	1248	59	1144	991
			domContentLoaded	1080	967	1242	60	1148	988
			domInteractive	17	13	70	8	16	30
			firstPaint	737	91	1221	438	220	987
			backgroundConnect	10	6	28	4	9	10
			firstReactRender	19	15	41	5	20	33
			getState	12	4	45	8	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	828	721	983	58	871	940
			setupStore	8	4	29	3	7	8
	Webpack	Home	uiStartup	2127	1703	2591	198	2272	2459
			load	1652	1320	1998	154	1760	1910
			domContentLoaded	1646	1316	1971	152	1755	1882
			domInteractive	16	12	60	8	14	42
			firstPaint	160	64	387	59	232	90
			backgroundConnect	29	11	92	15	33	73
			firstReactRender	163	54	375	114	69	96
			getState	12	3	181	18	8	9
			initialActions	7	1	235	32	3	5
			loadScripts	1637	1313	1945	151	1752	1857
			setupStore	62	6	305	98	287	8
Firefox	Browserify	Home	uiStartup	1439	1244	2122	177	1475	1865
			load	1288	1088	1925	172	1330	1690
			domContentLoaded	1288	1087	1925	172	1330	1689
			domInteractive	103	42	165	22	87	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	16	129	15	26	50
			firstReactRender	23	20	37	3	24	28
			getState	7	4	35	4	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	1263	1068	1895	166	1304	1671
			setupStore	7	4	87	8	6	8
	Webpack	Home	uiStartup	1547	1373	2060	158	1587	1948
			load	1331	1170	1806	145	1371	1709
			domContentLoaded	1331	1169	1806	145	1370	1709
			domInteractive	95	34	169	23	91	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	19	51	6	26	45
			firstReactRender	36	28	71	7	39	49
			getState	8	3	35	5	8	9
			initialActions	1	0	2	1	1	1
			loadScripts	1308	1144	1786	145	1344	1687
			setupStore	8	5	29	3	8	8

Bundle size diffs [🚀 Bundle size reduced!]

background: -561 Bytes (-0.01%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

Fix lint issues Fix unit test Return changes after conflict resolve (rebase) Revert unwanted controller changes

metamaskbot · 2025-05-05T10:58:54Z

Builds ready [51025f3]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1215 ± 70 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1215	1080	1436	70	1252	1369
			load	1056	953	1274	64	1089	1185
			domContentLoaded	1050	948	1270	63	1084	1179
			domInteractive	18	13	115	12	16	29
			firstPaint	710	81	1208	423	1075	1167
			backgroundConnect	7	4	29	3	8	12
			firstReactRender	20	16	42	5	21	29
			getState	11	5	32	6	16	25
			initialActions	0	0	1	0	0	1
			loadScripts	814	716	1031	60	845	935
			setupStore	7	5	14	2	7	10
	Webpack	Home	uiStartup	2113	1748	2415	160	2232	2350
			load	1627	1271	1871	129	1732	1802
			domContentLoaded	1620	1267	1867	129	1729	1797
			domInteractive	15	11	48	8	13	39
			firstPaint	195	72	1618	168	206	336
			backgroundConnect	26	11	66	12	30	54
			firstReactRender	207	55	379	123	345	362
			getState	15	4	404	40	14	29
			initialActions	3	1	7	1	3	5
			loadScripts	1615	1264	1866	130	1726	1794
			setupStore	22	7	292	36	20	37
Firefox	Browserify	Home	uiStartup	1352	1184	1627	102	1440	1531
			load	1209	1027	1506	105	1306	1387
			domContentLoaded	1209	1027	1506	105	1306	1386
			domInteractive	104	43	224	32	117	182
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	12	86	9	20	40
			firstReactRender	22	19	51	5	23	28
			getState	7	4	27	3	8	13
			initialActions	0	0	2	0	0	1
			loadScripts	1190	1014	1490	104	1281	1367
			setupStore	8	4	162	16	6	8
	Webpack	Home	uiStartup	1531	1373	2029	121	1588	1803
			load	1308	1189	1696	103	1352	1527
			domContentLoaded	1308	1189	1696	103	1352	1527
			domInteractive	77	51	130	17	83	119
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	14	91	11	26	44
			firstReactRender	36	29	66	7	39	50
			getState	10	5	31	6	10	29
			initialActions	1	0	2	1	1	1
			loadScripts	1288	1169	1670	103	1332	1510
			setupStore	11	5	256	25	9	31

Benchmark value 1369 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 337 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 31 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 0ms | Sum of p95 exceeds: 10ms
Sum of all benchmark exceeds: 10ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -561 Bytes (-0.01%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

This PR moves MetaMetrics tracking of Snap export usage to Snap Controller. Related issue: #3259 Extension integration PR: MetaMask/metamask-extension#31553 Mobile integration PR: MetaMask/metamask-mobile#14428

david0xd added the team-snaps-platform Snaps Platform team label Apr 3, 2025

david0xd self-assigned this Apr 3, 2025

david0xd mentioned this pull request Apr 3, 2025

feat: Add Snap export handler usage tracking MetaMask/snaps#3281

Merged

david0xd force-pushed the dd/change-snap-export-tracking branch from 42a4287 to de35e5f Compare April 3, 2025 11:21

david0xd mentioned this pull request Apr 4, 2025

feat(snaps): Add Snap export tracking hook to Snap controller init MetaMask/metamask-mobile#14428

Draft

7 tasks

david0xd force-pushed the dd/change-snap-export-tracking branch from d9d1973 to 78ecd22 Compare April 4, 2025 13:14

david0xd force-pushed the dd/change-snap-export-tracking branch 3 times, most recently from 7716eac to 7c83edf Compare April 24, 2025 11:00

Change Snap export tracking approach

51025f3

Fix lint issues Fix unit test Return changes after conflict resolve (rebase) Revert unwanted controller changes

david0xd force-pushed the dd/change-snap-export-tracking branch from 7c83edf to 51025f3 Compare May 5, 2025 10:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Snaps): Change Snap export tracking approach #31553

feat(Snaps): Change Snap export tracking approach #31553

david0xd commented Apr 3, 2025 •

edited

Loading

github-actions bot commented Apr 3, 2025

metamaskbot commented Apr 3, 2025 •

edited

Loading

metamaskbot commented Apr 3, 2025

metamaskbot commented Apr 4, 2025

metamaskbot commented Apr 4, 2025

metamaskbot commented May 5, 2025

feat(Snaps): Change Snap export tracking approach #31553

Are you sure you want to change the base?

feat(Snaps): Change Snap export tracking approach #31553

Conversation

david0xd commented Apr 3, 2025 • edited Loading

Description

Notes

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Apr 3, 2025

metamaskbot commented Apr 3, 2025 • edited Loading

✨ Files requiring CODEOWNER review ✨

metamaskbot commented Apr 3, 2025

metamaskbot commented Apr 4, 2025

metamaskbot commented Apr 4, 2025

metamaskbot commented May 5, 2025

david0xd commented Apr 3, 2025 •

edited

Loading

metamaskbot commented Apr 3, 2025 •

edited

Loading