chore: upgrade assets-controllers v62 #32546
Draft
+62
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
❌ API Spec Test Failed. View the report here. |
sahar-fehri
changed the title
sahar-fehri
commented
May 6, 2025
| @@ -112,7 +112,7 @@ export class MultichainWalletSnapClient implements WalletSnapClient { | |||
| // will be added to the Snap bridge keyring (see `MultichainBalancesController:#handleOnAccountAdded`). | |||
| // However, the balance won't be fetched right away. To workaround this, we trigger the | |||
| // fetch explicitly here (since we are already in a `async` call) and wait for it to be updated! | |||
| await multichainUpdateBalance(account.id); | |||
| // await multichainUpdateBalance(account.id); | |||
There was a problem hiding this comment.
@ccharly do you this this call is still valid?
There was a problem hiding this comment.
I think it's time we get rid of those now (even the transaction force-fetch down below).
Most of the controllers now either reacts to :accountAdded or to :account{AssetList,Transactions,Balances}Updated, so they would get those info "asynchronously".
Also, our preinstalled Snaps follow a different architecture now and they normally just fetch the balances/assets/transactions using a cron, so they might not have those info right away (unless they are force-fetching and blocking until they get the results in getAccountBalances and getTransactions...).
IMO, as long as we show a spinner on the balances until we get the Snap event :accountBalancesUpdated, we should be ok to remove those calls.
Builds ready [f27905d]
UI Startup Metrics (1213 ± 72 ms)
Benchmark value 1724 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1718 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 1713 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2508 exceeds gate value 2454 for chrome webpack home p95 uiStartup Sum of mean exceeds: 72ms | Sum of p95 exceeds: 54ms Sum of all benchmark exceeds: 126ms Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [e946876]
UI Startup Metrics (1233 ± 69 ms)
Benchmark value 1070 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 1184 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 2197 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 61 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Sum of mean exceeds: 20ms | Sum of p95 exceeds: 16ms Sum of all benchmark exceeds: 36ms Bundle size diffs [🚀 Bundle size reduced!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade assets-controller to v61 and integrate new perf updates here MetaMask/core#5761
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist